Craig Johnson
@craigdev937All comments
- @KireKostadinoskiSubmitted 5 months ago@craigdev937Posted 5 months ago
Hey, nice job. You might consider using object-fit for the image. Great job finishing your project!
Marked as helpful0 - @thisisadityaraoSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
This challenge was easy, so I'm not sure if I'd do something differently.
What challenges did you encounter, and how did you overcome them?Nothing in particular was challenging in this project.
What specific areas of your project would you like help with?Fortunately, I don't think I'll need any help. Though I'm open to any suggestions.
@craigdev937Posted 6 months agoGreat job on your solution. One thing that you might want to try is to link to the images in your Assets folder. For example:
/assets/images/avatar-jessica.jpeg
That will show the image on your webpage. Keep up the great work!
Marked as helpful1 - @angelica-vianaSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
Ter conseguido desenvolver o projeto com mais agilidade e conseguir ver minha evolução.
What challenges did you encounter, and how did you overcome them?Desafios com a estilização, consegui superar fazendo algumas pesquisas.
What specific areas of your project would you like help with?No momento nenhuma área.
@craigdev937Posted 7 months agoCongratulations on finishing the project!
You might consider using replacing the <div> tags with semantic HTML tags: <section>, <aside>, etc.
Another option would be to use a CSS naming convention such as BEM (Block Element Modifier). Here is a link with more info: https://www.frontendmentor.io/articles/understanding-css-naming-conventions-bem-oocss-smacss-and-suit-css-V6ZZUYs1xz
0 - @thebraudalfSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
You can make this card through rather than css flexbox via margin and padding.
What challenges did you encounter, and how did you overcome them?Firstly, I most difficult challenge I overcome, which was to make a responsive layout.
@craigdev937Posted 8 months agoHi I waned to check your website but there. You might want to try deploying your website on a free service like Netlify. Here is a link to a video demonstration. I hope that this helps?
https://youtu.be/y71SR-KcZCg?si=MQxivkj8ZFQ5ne8C
0 - @ziadx33Submitted over 1 year ago@craigdev937Posted over 1 year ago
Nice job on this challenge!
One suggestion is to change the width to 100%
.img-container img { display: block; width: 100%; height: 321.875px; border-radius: 7px; opacity: 1; }
The image will take up the full width of the container. I hope that helps?
Keep up with the coding! 🙂Marked as helpful1