ilehoe0202• 20
@ilehoe0202
Submitted
contrebasses
@contrebasses
All comments
- contrebasses• 40
@contrebasses
Posted
The code is very clean and readable.
Don't forget about the :hover style.
On the accessibility side, it's okay to have longer descriptions in an alt text e.g : "Author's avatar". Try to think about how it will sound to the user who has a screen reader.
Don't hesitate to refer to the .fig files for more accuracy with the colors.
It looks almost pixel perfect though.
0 - Luis David• 150
@TheLuuiis
Submitted
contrebasses• 40@contrebasses
Posted
Hi, I just looked at your QR code component.
The design is responsive. I tested the site on Chromium and Firefox on desktop and mobile and it looked good.
The alt text could be more detailed. Also, it's ok to rely more on the design system's variables for the spacing, typography and the box-shadow.
The code is highly readable though !
Marked as helpful
0
