contrebasses
@contrebassesAll comments
- @ArpitTheSlayerSubmitted 24 days ago@contrebassesPosted 22 days ago
I don't have much to say. This solution looks almost pixel perfect. It does what it's supposed to. I guess it could be scaled down a little bit. I tested it on Firefox and Chrome on desktop and mobile, and it's responsive. Great job. I'm actually getting inspired.
0 - @ilehoe0202Submitted 25 days ago@contrebassesPosted 25 days ago
The code is very clean and readable.
Don't forget about the :hover style.
On the accessibility side, it's okay to have longer descriptions in an alt text e.g : "Author's avatar". Try to think about how it will sound to the user who has a screen reader.
Don't hesitate to refer to the .fig files for more accuracy with the colors.
It looks almost pixel perfect though.
0 - @TheLuuiisSubmitted 7 months ago@contrebassesPosted about 1 month ago
Hi, I just looked at your QR code component.
The design is responsive. I tested the site on Chromium and Firefox on desktop and mobile and it looked good.
The alt text could be more detailed. Also, it's ok to rely more on the design system's variables for the spacing, typography and the box-shadow.
The code is highly readable though !
Marked as helpful0