Skip to content
OverviewSolutions
14
Comments
6
codewithxavi
@codewithxavi

All comments

  • codewithxavi•210
    @codewithxaviPosted almost 3 years ago

    With the instructions of brennaobrien, i could do the work, thanks man ^^

    1
  • codewithxavi•210
    @codewithxaviPosted almost 3 years ago

    Excellent feedback, I've just followed you on GitHub, the results are pixel perfect, I'm awesomed

    1
  • codewithxavi•210
    @codewithxaviPosted almost 3 years ago

    Hey bro, amazing job, i have a little question the input type range how you put the icon-slider.svg i am trying to do it, and i cant i dont know how to style the input type range accordingly to the design

    1
  • codewithxavi•210
    @codewithxaviPosted almost 3 years ago

    Hola @Hemsundar15 he visto el resultado y está fantástico, excelente, no he profundizado mucho en el código, lo que el dado le puedes poner al contenedor: para centrar el dado display: flex; justify-content: center; align-items: center;

    ¡Buen trabajo, un abrazo!

    0
  • codewithxavi•210
    @codewithxaviSubmitted almost 3 years ago

    Hola a todos, gracias por opinar y ver mi solución, os dejo un problema que me sucede. La imagen de fondo en desktop no se me acaba de ver bien cuando hago un zoom out, no llega a ocupar el 100% y no sé cómo podría arreglarlo, estaría agradecido si me pudierais ayudar con eso, muchas gracias ^^

    Order-summary-component-main

    3
    codewithxavi•210
    @codewithxaviPosted almost 3 years ago

    Muchas gracias por la respuesta, lo pruebo y te digo ^^

    1
  • codewithxavi•210
    @codewithxaviPosted almost 3 years ago

    Hey, I'm going to give you feedback. I know that this is your first challenge, I am not a professor but I can tell you some advice. I am watching your HTML and it has some errors, you can check that URL that is going to validate your HTML, https://validator.w3.org/nu/ (there is another website that can validate your CSS also). I can notice that you positioned the elements on the page but in an incorrect way, the things are not centered at all because you use a lot of margins and paddings. Margins and paddings are good but in a reasonable way, I recommend you to learn about flexbox and grid in the near future. Things will be easiest and also know the position of the elements of the HTML. If you have a div, an article, a section, a heading know if it is a display: block, display: inline-block, etc. You need to write the CSS in a more ordered way because if someone needs to write in your code to make it easier to understand, you don't write code to yourself only. Use an editor that helps you like Visual Studio Code. I know that this is a little bit extense, but this is my advice. Also, your code doesn't work well in mobiles, so you must work on the responsive a lot more. Thanks, and keep going on your challenges

    Marked as helpful
    0