Skip to content
OverviewSolutions
8
Comments
2
Ayush Patel
@codesbyayush

All comments

  • Udbhav Dalmia•150
    @UdbhavDalmiaSubmitted over 1 year ago

    First Question: I am having some problems vertically aligning items can someone help me with that?

    Second Question: I uploaded all the images in the GitHub repository but still the images are not showing on the live site. Does someone know why?

    Product-Preview-Card-Component

    2
    Ayush Patel•200
    @codesbyayushPosted over 1 year ago

    Hey I have made the changes you asked question for in your repo and created a merge request. There would be a request with my name on your github repo. Checkout the changes and let me know if you have any questions on how it works.

    I have made the body a grid layout to center the div in it.

    I have changed the file location in src attribute to show images and explained the reason in my pull request.

    Marked as helpful
    1
  • Ayush Patel•200
    @codesbyayushPosted over 1 year ago

    It's good to see that you make it work with relative layout. It must be a lot of work for you, try learning GRID and FLEX layout in css. They will help you make this layout more easily in no time and the layout thus formed will be more fluid.

    I wanted to highlight some improvements that could be made.

    • Instead of using <strong> tags, use a class and style it in css only.
    • try to reduce the use of <br> tags.
    • To get the profile pictures perfectly round (e.g. Kira, Jonathan, and Jeanette's), use border-radius: 50%.

    You could watch this youtuber for improvements in solution as he solved this challenge.

    1