Emmanuel Daniel
@coderdannieAll comments
- @charlsoluwapelumiSubmitted about 1 year ago@coderdanniePosted about 1 year ago
Hi. Congrats on the completion of this project. An extra features you can add is to store the themes state using browser localstorage so that your site can maintain the theme state even if the page was reload. Right now if I switch to light mode and reload the web page its switching back to the default theme. Using browser storage to store the theme and accessing the themes based on user preference will prevent this from happening. https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage
0 - @jen67Submitted over 1 year ago@coderdanniePosted over 1 year ago
Hi. Congrats on the completion of this project. An extra features you can add is to store the themes state using browser localstorage so that your site can maintain the theme state even if the page was reload. Right now if I switch to light mode and reload the web page its switching back to the default theme. Using browser storage to store the theme and accessing the themes based on user preference will prevent this from happening. https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage
Marked as helpful0 - @manavssSubmitted over 1 year ago
Everything seems fine in the development on large screen but for some reason the layout break after uploading to netlify.Do you know the reason?Any feedbacks would be appreciated.
@coderdanniePosted over 1 year agoHi. Congrats on the completion of this project. An extra features you can add is to store the themes state using browser localstorage so that your site can maintain the theme state even if the page was reload. Right now if I switch to light mode and reload the web page its switching back to the default theme. Using browser storage to store the theme and accessing the themes based on user preference will prevent this from happening. https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage
Marked as helpful1 - @lorenacrinconSubmitted over 1 year ago
Hi everyone!
I would appreciate it if you could give me some feedback on the structure of my code to see what I can improve.
Thank you!
@coderdanniePosted over 1 year agoHi. Congrats on the completion of this project. An extra features you can add is to store the themes state using browser localstorage so that your site can maintain the theme state even if the page was reload. Right now if I switch to light mode and reload the web page its switching back to the default theme. Using browser storage to store the theme and accessing the themes based on user preference will prevent this from happening. https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage
Marked as helpful0 - @coderdannieSubmitted over 1 year ago
Making this website responsive was a bit challenging for me with took me quite a long to complete. This is my first time building a project using react-router and I really learn extensively. The images in the data.json are broken so I had to use all other contents in the data.json except the pictures together with the local pictures provided so I manually inserted the pictures into the dom using ternary operators. This is the area of the code am not sure of although it worked quite perfectly. Am open to suggestions on how I can also improve my code as I believe that learning never stops. THANKS
- @Sharjeel14Submitted over 1 year ago@coderdanniePosted over 1 year ago
Hi. Congrats on the completion of this project. An extra features you can add is to store the themes state using browser localstorage so that your site can maintain the theme state even if the page was reload. Right now if I switch to light mode and reload the web page its switching back to the default theme. Using browser storage to store the theme and accessing the themes based on user preference will prevent this from happening. https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage
0 - @zahirpkSubmitted over 1 year ago
12th Junior Frontend Mentor Challenge(Social media dashboard with theme switcher) learn a lot of new things. Thank you frontend mentor community.
any feedback will be appreciated.
@coderdanniePosted over 1 year agoHi. Congrats on the completion of this project. An extra features you can add is to store the themes state using browser localstorage so that your site can maintain the theme state even if the page was reload. Right now if I switch to light mode and reload the web page its switching back to the default theme. Using browser storage to store the theme and accessing the themes based on user preference will prevent this from happening. https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage
0 - @KingJosephISubmitted over 1 year ago@coderdanniePosted over 1 year ago
Hi. Congrats on the completion of this project. An extra features you can add is to store the themes state using browser localstorage so that your site can maintain the theme state even if the page was reload. Right now if I switch to light mode and reload the web page its switching back to the default theme. Using browser storage to store the theme and accessing the themes based on user preference will prevent this from happening. https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage
Marked as helpful1 - @darkspeakerSubmitted over 1 year ago@coderdanniePosted over 1 year ago
Hi. Congrats on the completion of this project. An extra features you can add is to store the themes state using browser localstorage so that your site can maintain the theme state even if the page was reload. Right now if I switch to darkmode and reload the web page its switching back to the default theme. Using browser storage to store the theme and accessing the themes based on user preference will prevent this from happening. https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage
1 - @Dng120696Submitted over 1 year ago
any comment so I can improve my skill thank you
@coderdanniePosted over 1 year agoHi. Congrats on the completion of this project. An extra features you can add is to store the themes state using browser localstorage so that your site can maintain the theme state even if the page was reload. Right now if I switch to light mode and reload the web page its switching back to the default theme. Using browser storage to store the theme and accessing the themes based on user preference will prevent this from happening. https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage
1 - @Ali-Akbar-QasimiSubmitted over 1 year ago@coderdanniePosted over 1 year ago
Hi. Congrats on the completion of this project. An extra features you can add is to store the themes state using browser localstorage so that your site can maintain the theme state even if the page was reload. Right now if I switch to light mode and reload the web page its switching back to the default theme. Using browser storage to store the theme and accessing the themes based on user preference will prevent this from happening. https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage
0 - @babi-nosSubmitted over 1 year ago
ce challenge est bien il permet de travaillez les flexbox et de travailliez aussi un peux de javascript avec le DarkLight. les remarques sont les bienvenues. merci de m'avoir lu
@coderdanniePosted over 1 year agoSalut. Félicitations pour la réalisation de ce projet. Une fonctionnalité supplémentaire que vous pouvez ajouter consiste à stocker l'état des thèmes à l'aide du stockage local du navigateur afin que votre site puisse conserver l'état du thème même si la page a été rechargée. En ce moment, si je passe en mode clair et que je recharge la page Web, je reviens au thème par défaut. L'utilisation du stockage du navigateur pour stocker le thème et l'accès aux thèmes en fonction des préférences de l'utilisateur empêcheront que cela ne se produise. https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage
Marked as helpful0