Skip to content
OverviewSolutions
15
Comments
4
Muhammad Zohaib
@codefolk

All comments

  • Muhammad Zohaib•270
    @codefolkPosted about 2 years ago

    Congratulations on your new solution. In desktop view, give your body a width 100vw and height 100vh; along with the background-image you also need to give a background color which is given in styleguide.md and set them using background position. For the part of icons, you can enclose them in a div and give background color to that div. Happy Coding... :)

    0
  • irma•60
    @irmakaleemSubmitted about 2 years ago

    I find difficulty in image overlay and grid row . I've just started doing grids so I'm facing little bit difficulties.

    stats preview card using grid

    1
    Muhammad Zohaib•270
    @codefolkPosted about 2 years ago

    Hey @irmakaleem, Congratulations on your new solution. There are few suggestions I would like to give you. You should start with mobile view first and add complexities later. Avoid giving heights to elements the container will set its height depending upon the content in it. Also add a media-query at 768px to switch to desktop view for tablets and Pcs. For grid, also define rows even if there is one row. You can use grid-template-areas for specifying where the content belong in HTML. Try using % for giving widths, it's more responsive. For desktop view, you can use width:100vw and height:100vh to avoid overflow. Happy Coding.

    Marked as helpful
    0
  • chillz-the-first•150
    @chillz-the-firstSubmitted about 2 years ago

    As I was building this project, I had trouble with the form. I couldn't control when the :invalid pseudo-class would be active. So if anyone has tips on how I could fix my forms or any other part of my code can you please share them.

    Fylo landing page

    2
    Muhammad Zohaib•270
    @codefolkPosted about 2 years ago

    Hi chillz-the-first,

    Congratulation on completing another frontend mentor challenge. Excellent work! I have some suggestions regarding your solution:

    I have seen your website, everything is pretty good. Except for the part in Navbar in mobile view overflows. You can prevent it by setting with of Nav container to 100%. Also, try not to give height to your elements. Use ARIA landmarks instead of divs. Divs are only empty containers to make your HTML markup more meaningful try using associated tags.

    0
  • Muhammad Zohaib•270
    @codefolkPosted about 2 years ago

    Bs sai ae bhai tu ignore kar tu zara mil tera ilaj karna tu baz nai ana sidhi tarah tera keera marna paena ae pampoorya

    Does the solution include semantic HTML?
Is it accessible, and what improvements could be made?
Does the layout look good on a range of screen sizes?
Is the code well-structured, readable, and reusable?
    0