@FanushhhSubmitted over 1 year ago
P
cloudpc7
@cloudpc7All comments
- @cloudpc7Posted 8 months ago
Great job, I would change the footer though its not going all the way down, if you want to you can reference what I did for the footer.
0 - @stefan-holmgrenSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
Enjoyed the way one can utilize "grid-area".
What challenges did you encounter, and how did you overcome them?Mostly trying to keep the html light, and not as css-dependent as I usually do it.
What specific areas of your project would you like help with?Not really sure.
@cloudpc7Posted 8 months agoYour design looks picture perfect, but I notice that when you are using padding you are only giving 3 inputs, when doing padding I believe that it takes 4 top left down and right. also if the body is already declared without margin or padding @ 0, why put the body: unset again. And why unset just put margin: 0 padding 0; but this should go into the css reset stylesheet and * {} which is already in the css stylesheet.
0 - @mgra04Submitted 8 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud of completing my first challenge using grid.
What challenges did you encounter, and how did you overcome them?How to make title font-size scalable with the screen width. I used calc() to overcome it.
What specific areas of your project would you like help with?I'm not sure why when I set max-width of under title description to 54rem my cards also got that width.
- @stefan-holmgrenSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
Did it the mobile first way, and think it was a good approach.
What challenges did you encounter, and how did you overcome them?Challenging how abstract you want to make your classes - right now they are focused on what they are, more than what they do.
What specific areas of your project would you like help with?Abstraction of classes? Are functional classes better?
