Macdeesh• 610
@macdeesh
Submitted
Hey everyone! I've just completed the "NFT preview card component" challenge. Any feedback and suggestions on how I can improve are very welcome!
Hassan Abdulfatai-Ogunniyi
@cloudmate404
All comments
@cloudmate404
Posted
Honestly I don't see a problem, you did well!. Keep trying out new challenges and keep improving
0- Hassan Yahya• 250
@hassanyahya400
Submitted
1). How do I align the background image of the header to be pixel perfect
2). The grid images at the about section is not aligning very well at medium screen sizes, how can i fix it
3). I'm unable to set the overflow of the nav-links in mobile version, if i set overflow-x to hidden the button in the nav-link will be affected
@cloudmate404
Posted
Hey namesake,
Your question one, I'm not sure what you are trying to ask.
But there are some things i noticed while checking your code, I may be wrong but I will list them
- I think you assume that the images given to you are exact dimensions which isn't the case most times. Most times you have to control your image properties with classes in css to give you the exact appearance you want. This should help your no 2 question. I played a bit with your code and applied a width of 100% to your destop-img class.
- I think it's best to keep your media queries at the bottom of your code, this will help you prevent overwriting properties by mistake.
- I noticed you added both your desktop and mobile images, i may be wrong here but i feel just the desktop image is fine and you can adjust the properties when needed.
0 - JESSE OGBONNA• 570
@JesseOlisa
Submitted
Feedbacks on my solution are welcome.
@cloudmate404
Posted
Hi Jesse,
I just wanted to say good job and keep engaging in projects, you will definitely keep getting better with JavaScript. Also, I want to point out the use of semantic HTML like <section> <header>, we are all guilty of this especially we that are just starting up.
again, Great job!
Marked as helpful
1
