All comments

• 

  Marek Witkowski•10

  @mwitkowski96Submitted almost 2 years ago

  What did you find difficult while building the project?

  • I wasn't sure how to center the card in viewport.

  Which areas of your code are you unsure of?

  • I'm just thinking about all these margins, to seperate elements. Not sure if that's the best way to do it.

  Do you have any questions about best practices?

  • Is the HTML structure correct?

  

  Responsive card using % sizes, set with display: flex

  1

  10
  

  Curtis•30

  @cl8396Posted almost 2 years ago

  • You can use display: grid place-items: center on the body to center the element in the middle of the page. I woudn't use this if there is more than one element in the body.

  • To create the required spacing, margins can defintely work. To cut down on writing lots of the same CSS, you could use a utility class like the one outlined here

  • The HTML structure looks good to me.

  • I would make sure your sizing adheres closer to the design.

  0