Skip to content
OverviewSolutions
23
Comments
4
Chris
@chrisvn188

All comments

  • Chris•400
    @chrisvn188Posted almost 2 years ago

    Woohoo 🎉 After one month doing project, I finally completed this big project using ReactJS, Typescript( first project using it ), styled-components for styling. I learned a lot from this project. When I started it, I did not know how to finish it. But with right strategy, I did it 🚀 🎉 🎊 . I build a simple component system to reuse through the app. I built general small things such as Button, Typography, Container, Flex, Grid then build bigger components using them. I still need to check if it looks good on different screen sizes, add some interesting animation to make it more appealing and make sure the code is more readable. If you guys can spot bugs, feel free to point it out. I really appreciate that. Any feedbacks are really valuable to me. Thank you all and happy coding!

    0
  • Chris•400
    @chrisvn188Posted about 2 years ago

    Hi GABRIEL, Congratulation on completing this project. I really like your idea of transforming border countries. I suggest you can add feature like map using Google Map Api or some features using it for your project. I'm not familiar with SvelteKit, so I'm not sure about the code. Anyways, great job! Happy coding!

    0
  • Fluffy Kas•7,715
    @FluffyKasSubmitted almost 3 years ago

    Hey hey,

    This was a very small challenge that I did more for completeness sake than for anything else. Made it into a speedrun, to see how fast I can deploy. :)

    If you have any feedbacks though, feel free to add.

    Have a great day!

    QR code component

    1
    Chris•400
    @chrisvn188Posted almost 3 years ago

    @FluffyKas Hey I really like the way you structrure your code. It's nice and neat. I just wondered do you always use <figure> to wrap around img? When you write figcaption and when not? Thank you so much!

    2
  • Chris•400
    @chrisvn188Posted almost 3 years ago

    @saripovdenis Hey! Congratulation on the first project! It looks great! I had a look at your html and I see that you are trying to use BEM naming convention for classes. For better practice, "No matter how many levels deep a descendent is nested the double-underscore pattern should appear only once in his selector name." You can read more here: https://assist-software.net/blog/css-guideline-tutorial-bem-sass

    • eg: instead of writting class="card__content__body", you just write class="card__body"

    Hope it will help! Happy coding!

    Marked as helpful
    1