@ali-reza-2531Submitted 3 days ago
P
Christian
@christianb3llAll comments
- @mojtaba-mehrzadSubmitted 7 days ago@christianb3llPosted 7 days ago
A really nicely done solution! Very accurate to the design.
1 - @2XG-DEVSubmitted 16 days ago@christianb3llPosted 16 days ago
Nicely done! Only difference to the design I saw was the lack of active/hover states for the share button
1 - @DavyZaneSubmitted 23 days agoWhat are you most proud of, and what would you do differently next time?
This challenge brings together all the know-how learned so far, I am happy to have been able to go all the way. I took my time, I came up against many difficulties but almost every time I quickly found a solution. That's the job that comes in!
What challenges did you encounter, and how did you overcome them?Three big challenges: 1. make the hero image overflow on both sides of the screen. I didn't manage it but I think it's just a minor detail so I didn't bother. 2. Put two hero images on the desktop version. I ended up putting all the hero images in the html, then making the ones I wanted appear in the css (display: none / display: block). I don't know if this is a good way of doing it! 3. I had a lot of trouble getting the background image to fit into the footer as I wanted because I didn't know this function well. After playing around a bit and trying different combinations, I finally settled on a largely acceptable solution.
What specific areas of your project would you like help with?I haven't had any major difficulties to overcome yet, however I welcome any advice!
@christianb3llPosted 21 days agoGreat job! It's really accurate to the design. Espescially the hero images. I wasn't sure on the best way to tackle showing/hiding the hero images either. I opted to use the picture tag to swap the left image with the main image on lower screen sizes. Then I just hid the right hand image. I don't think there's an elegant way to do it really.
0 - @loiccapeSubmitted 22 days agoWhat are you most proud of, and what would you do differently next time?
I start to improve on css Selector , so i did less code , i think this is a good start. I will probably try to find better way to change design of box and keep my code easyer to read for other people
What challenges did you encounter, and how did you overcome them?i did not realy encounter big challenges on this project.
- @KasiaKaz14Submitted 23 days agoWhat are you most proud of, and what would you do differently next time?
I am proud I manage to some problems I met at the end of the project. I could not arrange the four section in the way how it looks like on the template. Finally I did it, using position and setting the width of the whole container. I also expected to do it faster, but ok. I can accept the whole time to finish the design
What challenges did you encounter, and how did you overcome them?The biggest challenge was to arrange the four sections. As I wrote I did it with position. Maybe it is not the next solution, but I am glad that it works properly. Certainly, if someone has a better solution for this part of the project, and wants to share - I am open for the conversation, and will grateful for an advice
What specific areas of your project would you like help with?I think I have already characterised the main issue. Maybe it is not a big problem, but every advice/tip is at a premium
@christianb3llPosted 23 days agoGreat job! It looks great on desktop and mobile but the sizes in between force the user to scroll horizontally. Other than that all good!
0 - @2XG-DEVSubmitted 24 days ago
