Skip to content
OverviewSolutions
10
Comments
11
P
Greg Perry
@chizy21

All comments

  • Achmad Anwar Asyirri•100
    @asyirriSubmitted about 2 months ago
    What are you most proud of, and what would you do differently next time?

    Im still using native html and css, but still learning to how to use a framework or library for next project. this is one is much simpler than what i thought

    What challenges did you encounter, and how did you overcome them?

    After multiple challange from front end mentor, this one is quite easy one maybe the challange is how to organize

    What specific areas of your project would you like help with?

    Still my biggest weakness is, Im still using flexbox not using grid. maybe later i try using grid with simpler layout

    Four card feature solution

    1
    Greg Perry•190
    @chizy21Posted about 2 months ago

    Forgot to do the accessibility, need to work on that next.

    1
  • Greg Perry•190
    @chizy21Posted 3 months ago

    I liked the use of CSS variables. Nice html structure as well. Great Job.

    0
  • Greg Perry•190
    @chizy21Posted 3 months ago

    Great job with the HTML layout, there are some duplicates in the CSS that could be cleaned up.

    0
  • Greg Perry•190
    @chizy21Posted 3 months ago

    Nicely done and with minimal css as well.

    Marked as helpful
    1
  • Greg Perry•190
    @chizy21Posted 3 months ago

    Nice job, spot on

    0
  • Greg Perry•190
    @chizy21Posted 4 months ago

    no image showing, headings and text centering not working.

    0
  • Greg Perry•190
    @chizy21Posted over 1 year ago

    Good layout, well done.

    0
  • Greg Perry•190
    @chizy21Posted over 1 year ago

    Code layout is great, UI looks great, besides the dashes are not centered. Other than that, great job.

    0
  • Greg Perry•190
    @chizy21Posted over 1 year ago

    I would place your color variables in the global * instead of the html... this is my default.css for the resets.

    /* ------- / / reset / / ------- / / https://piccalil.li/blog/a-modern-css-reset / / Box sizing */ *, *::before, ::after { box-sizing: border-box; } / Colors */

    • { --color-white: #FFF; --color-black: #000; --color-purple: Purple; } /* Reset Margins / body, h1, h2, h3, h4, h5, p, figure, picture { margin: 0; } / Set core root defaults / html:focus-within { scroll-behavior: smooth; } / Set core body defaults / body { min-height: 100vh; text-rendering: optimizeSpeed; line-height: 1.5; } / Make images easier to work with / img, picture { max-width: 100%; display: block; } / Inherit fonts for inputs and buttons / input, button, textarea, select { font: inherit; } .container { max-width: 1140px; } / Remove all animations and transitions for people that prefer not to see them */ @media (prefers-reduced-motion: reduce) { html:focus-within { scroll-behavior: auto; } *, *::before, *::after { animation-duration: 0.01ms !important; animation-iteration-count: 1 !important; transition-duration: 0.01ms !important; scroll-behavior: auto !important; } } .attribution { font-size: 11px; text-align: center; } .attribution a { color: hsl(228, 45%, 44%); }
    Marked as helpful
    0
  • Greg Perry•190
    @chizy21Posted over 1 year ago

    Too many blank lines in your html, Other than that, layout is spot on. Great job on this project.

    0
  • Greg Perry•190
    @chizy21Posted over 1 year ago

    Nice layout, clean code. Great Job.

    Marked as helpful
    0