Skip to content
OverviewSolutions
17
Comments
4
Chris
@chintriago

All comments

  • Chris•250
    @chintriagoPosted 11 months ago

    Looks great and code is very readable with your naming conventions! My only advice would be to use more semantic HTML like MAIN and SECTION instead of DIV.

    Marked as helpful
    0
  • Chris•250
    @chintriagoPosted over 2 years ago

    with "<input type="email" the input field gives you an automatic message from the browser when entering an invalid email and not your own error message. You should change it to "<input type="text". Other than that great job! It looks just like the original and very responsive. I had issues with mine so I will be definitely be studying your code :)

    1
  • Julian•280
    @Julr09Submitted about 3 years ago

    I had a little problem with the background images, they were moving along with the divs so i made the body relative and the main absolute and it worked, please let me know if there is a better way, also for the background in the card I had to set a height to an empty div, again would like to know if there is a better way, those were the issues that i had here but any suggestion is welcome, also a bad practice spotted would be great to correct it now. Thank you.

    Profile card

    1
    Chris•250
    @chintriagoPosted about 3 years ago

    Hey I just posted the same challenge and was trying to figure out how to make the background images stay in place. This really helped me out! Also I didn't know about the four-value syntax for background-position or even using VW on them. My question is how did you come to the realization changing position for the main and body would fix the background image problem? Also, to get rid of your accessibility issue you just need to add an h1 tag, other than that it looks good and responsive!

    0
  • Chris•250
    @chintriagoPosted about 3 years ago

    It looks really good and close to the original! also the responsiveness is good. As for feedback, You forgot to change the background-color of the body to very light gray, the lower case s in SUVs, and it's really hard to read your bottom footer. I'm not too familiar with the accessibility side but you should look into it since it says there some issues.

    Marked as helpful
    1