@alphandlouis
Submitted
@cbserra
@alphandlouis
Submitted
@cbserra
Posted
I'm unable to get the map to load in any scenario. On initial page load, I receive these errors in the console (Chrome Canary browser):
ajax.js:143
GET https://api.mapbox.com/styles/v1/daniel-gp/ckqtg9brz5axa18qs0ic1dhdo?access_token=pk.eyJ1IjoiZGFuaWVsLWdwIiwiYSI6ImNrcXRmNXliYzA3bTIycHA4c2pycjNyeXQifQ.mTaMRpxwC6qtPk1-VefRJQ 401 (Unauthorized)
u @ ajax.js:143
(anonymous) @ ajax.js:185
At @ ajax.js:241
t.getJSON @ ajax.js:252
loadURL @ style.js:253
_updateStyle @ map.js:1420
setStyle @ map.js:1395
Map @ map.js:511
(anonymous) @ map.js:2
evented.js:149
Error: Unauthorized: you may have provided an invalid Mapbox access token. See https://www.mapbox.com/api-documentation/#access-tokens-and-token-scopes
at ajax.js:149:33
@cbserra
Submitted
Working on supporting multiple APIs, in case users prefer APIs other than the one recommended with this challenge (has limited API responses in free version -- and if you're a noob like me with useHooks, you can squander all API requests in a matter of seconds 😅
@cbserra
Posted
Boo -- latest solution wont load quickly enough for snapshot tool to capture the loaded site
@ajsaule
Submitted
Hey everyone, I mostly followed the requirements for this challenge but:
I would like to have a text field so users can type their password and see how long it would take to get cracked by a hacker.
If anyone has some feedback on anything, please leave me a comment.
@cbserra
Posted
So I was feeling a little ambitious (or just avoiding my own work) and mocked up an idea for your tool. You can check it out here:
https://codepen.io/cbserra/pen/RwyqpVW
JS wasn't added, so just CSS design purposes:
Figured maybe you could have a menu at the top to toggle between Password Generation and Password Analysis for a user's own password.
I updated the sections you added to match the Strength box.
Let me know your thoughts!
Marked as helpful
@chizoba-009
Submitted
Please drop a comment and review, thanks
@cbserra
Posted
e.g. <div> cannot be placed in <ul>/<ol> elements — only <li> elements are allowed. Also, <li> elements must be in <ul>/<ol> tags — they cannot exist outside of list elements
Marked as helpful
I want to know the other approach of displaying the different image for Mobile and Web view ? I am happy to take feedback on other best responsive design ways.
@cbserra
Posted
You could use the <picture> element, which allows you to specify @media queries for image sources.
Also, I found it easier and cleaner to develop my layout for mobile -- so the default CSS is targeting a mobile layout. That way, I only need a media query for additional breakpoints I will support. It looks like there's a large range between your breakpoints -- you have one for max-width of 541px and the other one is for min-width of over 1000px -- which leaves both images visible for at least one breakpoint between the two you support.
@hade963
Submitted
How could i align the image in mobile view?!
@cbserra
Posted
When I did this challenge, I added the illustrator image as an img
and not a background
. I used flexbox: for desktop, it followed the default flex-direction: row
, and for mobile, I changed that to flex-direction: column-reverse
so the image would appear first.
@techmithlesh
Submitted
Hi developers. Today I just finished the link Shortner app challenge from Frontend mentor. Please review it and let me know your suggestion and feedback.
@cbserra
Posted
maybe I’m overlooking it, but are the raw source files available to view? I only see the minified files, which are difficult to read.
a couple of spelling mistakes — “shortner “ below the header should be “shorter” and “Advance Statics” should be “Advanced Statistics”. Just two I saw.
was it your intention for the menu to follow the page on scroll? Just wondering it was a feature or a bug 🙂
@davitJabushanuri
Submitted
@cbserra
Posted
Looks good! I like how the code is organized. A couple of things I notoce (iPhone 11 Pro / Safari)
margin: 0; padding: 0
too html
and/or body
elements may fix those last 2 issues?