@JSinahySubmitted about 4 years ago
I would like your comment to my challenge, I have some details with the responsive theme and the dark theme functionality.
Cat Ballar
@catcarbonellAll comments
- @catcarbonellPosted about 4 years ago
At a high-level, the layout is great! Almost spot on. The percentages at the bottom should be aligned at the baseline of the larger number to the left.
Your dark mode toggle isn't working :( Perhaps try out doing the dark mode version!
2 - @michellerachoSubmitted about 4 years ago
Hi I would love some feedback especially in my usage of grid and flexbox. I struggle with the 'flex' property so I ended up using 'width' when styling the flexbox items. Thanks in advance!
@catcarbonellPosted about 4 years agoYou did great! Everything looks orderly and just like the mockup. I could nitpick at font-size or div height, but you know what? You nailed grid and flexbox. Keep up the awesome work!
1 - @MishaHernandezSubmitted about 4 years ago@catcarbonellPosted about 4 years ago
Awesome job! This looks amazing! I believe you got the design spot-on. Keep it up!
1 - @jeremyazaSubmitted about 4 years ago
Can I use many divs for the HTML structure?
@catcarbonellPosted about 4 years agoSure, you can use many divs for structure--but do you really want to? Accessibility would be an issue there, especially if you're just using divs. Also, your back-end dev might not appreciate that. Also, try out making it responsive! The vast majority of users are mobile-only, so you should practice!
One thing I really liked was the implementation of the animated share bubble. I appreciated the smooth transition!
3
