@wesen
Submitted
I went a bit deeper with this one. I used next and supabase, deployed on vercel. I created a reducer for the state handling, with jest unit tests. It was fun!
@carlwicker
@wesen
Submitted
I went a bit deeper with this one. I used next and supabase, deployed on vercel. I created a reducer for the state handling, with jest unit tests. It was fun!
@carlwicker
Posted
Hey ya Joako, great work on the layout, I noticed a few minor issues.
Keep up the great work.
Marked as helpful
@cssbubble
Submitted
@carlwicker
Posted
Hey ya Priyanka, great job on the layout, looks really good. There are however a few functionality issues...
Keep up the great work!
@washington299
Submitted
the focus on the project was to write tests, feel free to give me any advice about my tests and what i could do better :).
Ps: i didn't do the drag and drop and theme switcher functionalities because my focus was on tests.
@carlwicker
Posted
Hey ya Washington, everything looking good.. I only have a couple of suggestions...
Great work!
@nuel1
Submitted
@carlwicker
Posted
Hey ya, just been checking out your solution. There are a few issues, the most important is the speed. There seems to be bottleneck somewhere, as the data is very slow to return.
It might be worth getting the all API data once and storing it (since it doesn't change) to reduce APIs calls. Maybe that slowing it down, but haven't looked into your code.
Also...
Layout is looking good, I like your tweaks to the original design.
Keep up the great work.
Marked as helpful
@CrystalNyein
Submitted
Feedbacks are appreciated.
@carlwicker
Posted
Hey ya Nyein, Great job, I cant see any issues. There is a weird media breakpoint on the desktop version which makes stuff jump around. Personally I'd lose the additional break point.
Keep up the great work.
Marked as helpful
@Manik2375
Submitted
No questions, of course any criticism?
@carlwicker
Posted
Hey ya manik, good job on the layout. There are a couple of issues...
Keep up the great work.
@dusanlukic404
Submitted
Every feedback or suggestion would be very helpful 😁
@carlwicker
Posted
Hey ya Dusan, all looking good however I've noticed a few small issues.
Keep up the great work.
Marked as helpful
@saykeed
Submitted
hy guyz, kindly rate this project, its my first project building with json, you can click the daily, weekly and monthly button to display the data thanks
@carlwicker
Posted
Hey ya Saykeed, the functionality all seems to be working fine however the styling isn't quite right yet. Firstly I'd go through the report and address the issues, start by changing the ids to classes which will clear lots of your reported errors.
Here's the link for your report if you haven't seen it: https://www.frontendmentor.io/solutions/css-and-javascript-json-xOO-pLf5Y/report
"id" can be used on an HTML element that appears once on a page, however "class" can be applied to multiple HTML elements.
The style guide document provides links to the relevant fonts, font sizes and colors, they don't seem to be applied to your solution so take a look at that after you've addressed the report issues.
Keep up the great work.
@NomiDomi
Submitted
For this project I focused a lot on CSS variables and how to use them properly (check my README.md file for more info). I also kept my code as DRY as I could.
Not super happy with the way I dealt with the background images and couldn't find a solution that did it better. Any suggestions?
And as always, I appreciate any feedback! :)
@carlwicker
Posted
Really great work, consider fixing those accessibility issues in the report.
Keep up the great work.
Marked as helpful
@mario-santoro89
Submitted
Guys, i made some modification to the code saved succesfully in github(ex the right directory for the images since i'm not still able to create a folder or the js modification for not sliding up a div when opened :)) but the live version still goes on the previous version that i uploaded...am i missing something? thank you! oh, and what size is better to use instead of pixels?Ciao!
@carlwicker
Posted
Hey ya, good job so far... you're not far off getting it right.
Not sure what's going on with your git problems.
Marked as helpful
@ninjacanthi1995
Submitted
@carlwicker
Posted
Hey man, good job on the layout however there are some issues that should be addressed.
Finally fix those accessibility and HTML issues in the report.
Keep up the great work.
Marked as helpful
@BenjaDotMin
Submitted
Hello all! Today I learned about managing global state, using React and Redux. As always, pointers are welcome!
Thanks very much.
@carlwicker
Posted
Great job on the layout, however there are a few other issues that I thought I'd bring up for consideration.
Keep up the great work.
Marked as helpful