Filip Juszczak• 690
@filipjuszczak
Submitted
caner404
@caner404
All comments
- caner404• 280
@caner404
Posted
Hello there 👋 . Good job on completing the challenge!
I have a suggestions about your code that might interest you.
Unfortunately, when I try to fill out the form without input values, the error messages for the form fields are not displayed. I think this is due to the required-attribute on the respective input fields, because the HTML5 built-in error message is displayed.
Still very cool how you solved the modal and the form logic without a third party library!
0 - Nikhil Bhaladhare• 290
@nikbhaladhare2104
Submitted
What are you most proud of, and what would you do differently next time?
..
What challenges did you encounter, and how did you overcome them?
..
What specific areas of your project would you like help with?
..
caner404• 280@caner404
Posted
Hi Nikhil, good work completing the challenge. I have two small suggestions for improvement.
- on 2k monitors the header unfortunately breaks apart.
- from an accessibility point of view it would be very cool if you could open/close the accordion with the keyboard. You could maybe put the <img> tag in a <button> tag.
Otherwise keep up the good work and have fun coding!
0 - Alejandro• 380
@adelayglesiafleitas
Submitted
What are you most proud of, and what would you do differently next time?
I decided to try the Animate.css library to make the visualization more dynamic and engaging.
What challenges did you encounter, and how did you overcome them?
I added a counter to the final page to make a loop and prevent it from being static. I think that was the most fun part of the code.
What specific areas of your project would you like help with?
I would be very grateful for any help in improving the code.
caner404• 280@caner404
Posted
Hi Alejandro, I think your solution turned out well. Especially the animations are great. I have two small suggestions for improvement.
I would use an array.map() at this point to reduce code duplication.
<div className="container-buttons"> //instead of this <Score number={1} score={score} setScore={setScore} /> <Score number={2} score={score} setScore={setScore} /> <Score number={3} score={score} setScore={setScore} /> <Score number={4} score={score} setScore={setScore} /> <Score number={5} score={score} setScore={setScore} /> // you can do this [1,2,3,4,5].map((value) => <Score number={value} score={score} setScore={setScore} /> </div>The counter is a nice idea, but I think it would make more sense if it went down instead of up. At the moment it counts from 0 to 3 and resets the component. I would suggest that it goes down from 3 to 0.
Marked as helpful
0
