Skip to content
OverviewSolutions
4
Comments
1
buddhi-ashen
@buddhi-ashen

All comments

  • Julio Cinquina•270
    @JulioCinquinaSubmitted over 2 years ago

    What tag should I use for the card title to give it the best HTML semantics? I used <h1> for the title of the card, since it is the only <h1> in the page. However, this is not ideal if I were to reuse the card component in a page with more content. I'm also not sure if a heading tag is even the best option for a card title.

    I used "max-width: min(80%, 300px)" to make the card width match the design, as well as to prevent it from going edge to edge on small screens, but I'm using a "magic number" here. Is there a better approach to this?

    Any other comments are more than welcome. Thank you!

    Card component with accessible contrast, custom properties, and BEM

    2
    buddhi-ashen•40
    @buddhi-ashenPosted over 2 years ago

    What tag should I use for the card title to give it the best HTML semantics? I used <h1> for the title of the card, since it is the only <h1> in the page. - add classes for h1,. it make your code more accessible.easy to use in css.

    use different heading tags. like h3 or h2

    cheeres for your challenge!

    1