Bruna Gonçalves
@brunagoncalvesAll comments
- @UnifiesSubmitted 2 days ago@brunagoncalvesPosted 2 days ago
I found your code to be well structured, it used good css practices. Excellent work.
1 - @hubertasGeciauskasSubmitted 4 days agoWhat are you most proud of, and what would you do differently next time?
I'm proud that this time it was easier to read from the Figma designs, which streamlined the development process.
What specific areas of your project would you like help with?I'm looking for feedback on my CSS custom styles. Are they effectively set up for responsive design, or would it be better to implement a mobile-first approach? Any specific suggestions for improvement would be appreciated.
@brunagoncalvesPosted 4 days agoHello everything is fine!
Analyzing your CSS.
- Adding a CSS reset is generally a good practice as it helps with consistency between browsers. Examples (https://meyerweb.com/eric/tools/css/reset/), (https://www.joshwcomeau.com/css/custom-css-reset/).
- Define variables for colors.
- Instead of setting fixed sizes for the .card's width and height (384px and 522px), use max-width and min-height to allow the element to fit better on different screens. This is especially useful for devices larger and smaller than the specified values.
- Swap px for rem in fonts, using px can limit flexibility and responsiveness. It can change in other classes that have px as well.
- Add a 1rem padding to the body, so that on smaller devices the card does not touch the edge of the screen.
Marked as helpful1 - @tobaojoSubmitted 8 days agoWhat are you most proud of, and what would you do differently next time?
This is my first post to frontend mentor. I have never done anything like this before. It was also my first time using SASS. I have used css before but I wanted to try something new.
Not sure what I would do differently just yet.
What challenges did you encounter, and how did you overcome them?Getting setup with SASS. As I have never used it before I was a bit anxious of using something new and getting to grips with it. I pretty much bumbled my way around and watched a few videos on how to get started.
What specific areas of your project would you like help with?Any insights on code quality and best practices. I never really get a chance to work with other developers, so everything I know / don't know is from my own experiences.
@brunagoncalvesPosted 7 days agoI found your code to be well structured, Sass when we learn how to use it is very good. I liked how you solved this challenge.
0