Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • @denissejoyce

    Submitted

    Hey there, thank you for checking out my solution for this challenge. Please lmk if you find any issues or if you have any suggestions on how I can improve my code/implement best practices 🫶🫡

    Stuff I struggled with:

    • positioning the attribution for mobile and tablet view (I was able to work on this but I'd love to find a better solution!)
    Brian 180

    @brian7homas

    Posted

    Hi denisse,

    I think one of the more 'standard' ways to keep the footer at the bottom of viewport would be to follow some of the techniques on MDN web docs

    hope that helps!

    1
  • Davide 330

    @deedeedev

    Submitted

    I wanted to try styled-components but I'm not fond of the CSS-in-JS approach.

    I'm not sure I nailed the responsive aspect, it looks maybe a little weird around 700px, just before it switches to mobile design.

    I also changed the breakpoint to an arbitrary value: 600px, is this correct or should I try to make it fit into more standard breakpoints like 640px, 768px etc?

    Is there something I can do to improve the responsiveness?

    Brian 180

    @brian7homas

    Posted

    Hello Davide,

    Styled components do take some getting used to.

    One thing I would suggest is to use a function for your media queries, with styled components it becomes easier to add “logic” to your styles.

    I’ve normally stuck to standard breakpoints and have used a tool called Responsivly to help decide what breaks to include.

    I do a pretty basic version of using functions to return media queries in my Responsive dashboard solution

    Hope that helps

    0
  • NBD 240

    @bdal90

    Submitted

    Dear All,

    Here is my very next challenge, it took a loooong long time to do, but eventually I am done. Javascript is a hard nut to crack for me and I was trying to bring the best out of it. Hope it seems okay and so does my CSS. Any suggestion on HTML tagging maybe? Or anything at all?

    Thank you for checking it out,

    Cheers to you all,

    Dalma

    Brian 180

    @brian7homas

    Posted

    Hello 👋,

    Your JavaScript looks pretty clean for a project this size. The only thing I’d add is margin:0 auto to .text-side__first-heading and see if it aligns it center on mobile.

    Great job!!

    1
  • @CavaliereDavid

    Submitted

    What did you find difficult while building the project?

    1. Making It responsive, It is still not clear to me how to do so and when I define media queries I have the issue.
    2. Positioning elements

    Which areas of your code are you unsure of?

    1. My container was not correctly aligned and I used margins

    Do you have any questions about best practices?

    1. Starting with mobile development since the way to ease the load on the project because then It is easier to work on the desktop part, however I am not sure if It is the modern approach.
    2. How to make pages more responsive
    Brian 180

    @brian7homas

    Posted

    To make the page responsive you’d need to include the styles you want to override in a media query.

    Margin 0 auto should be enough to center the container.

    1
  • Brian 180

    @brian7homas

    Posted

    Cool idea to switch game modes, I’ll have to add that to mine

    0
  • P

    @amyspencerproject

    Submitted

    This was a tough challenge but I gained so much experience using CSS Grid. The key lesson for me was to keep it simple and not try to use columns as margins.

    Let me know what you think of my code.

    Brian 180

    @brian7homas

    Posted

    Love your comments, very easy to follow 👍

    1