Skip to content
OverviewSolutions
3
Comments
4
Boris
@borakb

All comments

  • Boris•110
    @borakbPosted almost 3 years ago
    1. The image hover overlay and the image have different border-radius
    2. The Ethereum and the Clock icon are not aligned in the middle of their container, to fix this add display: flex and align-items: center to the .price and the .time-left div elements

    If this has helped you I would appreciate if you could mark my feedback as useful! Thank you for reading.

    Marked as helpful
    1
  • Mônica Aparecida Kerber Dalosto•100
    @MonicaDalostoSubmitted almost 3 years ago

    Hey Folks, I've just finished my second project, and I'd really appreciate any feedback to help me improve my code. I didn't use bootstrap or other tools like that. How can I improve or make my code more advanced... As a newbie, I am open to any other suggestions. Thanks in advance!!!

    Html, Css

    5
    Boris•110
    @borakbPosted almost 3 years ago

    Hello! Amazing solution. Just a suggestion in case you didn't know, when you shrink the size of the screen too much, the qr code card does not shrink with the screen because of the hard-coded width value with it so in order to "fix" this is to set the max-width property to the desired value instead of setting the width property so that the box can become smaller if it does not have space. Also when you add this, adding some padding to the body would be good so that it does not touch the "walls" when it fits 100% width of the body but this would ruin your pixel-perfect solution by a bit probably. Summary: remove width property from .main-container and use max-width instead :)! I hope this helps and try experimenting with it.

    Marked as helpful
    1
  • Boris•110
    @borakbPosted almost 3 years ago

    Good job on the solution, however a common mistake that everyone, including me made is that the title Equilibrium #3429 takes up the whole width, and if you hover the right part of the container in empty space it will still have the hover effect. Fix this by setting the title's width to fit-content. Also on the hover overlay for the image, you forgot to give it a border-radius. I hope that my feedback helps.

    Marked as helpful
    1
  • Boris•110
    @borakbPosted almost 3 years ago

    Hello! Good job on the design, here are some stuff that need to be fixed.

    To the .main__author class, add align-items: center in order to center the author image and the text next to it, and also the title Equilibrium #3429 has the hover effect range in the whole container's width, to fix this, set the title's (.main__title) width to fit-content.

    Best of luck! I hope this has helped you.

    Marked as helpful
    0