Skip to content
OverviewSolutions
4
Comments
2
bonniemira
@bonniemira

All comments

  • bonniemira•60
    @bonniemiraPosted over 1 year ago

    Hey Atthawut, looks great! You did a really nice job on matching the visual design of your challenge to the template. One thing that you might want to consider in the bottom right section is using an unordered list instead of a single paragraph. This will help the text line up with the template properly; you can easily adjust the formatting, line spacing, etc. as you need.

    Additionally - I got a helpful comment about this on my very first project - your HTML could use a few more semantic tags to improve your accessibility score as well. :) There's 3 divs in your body that could be renamed to header, section, main, aside, or other appropriate tags without affecting the formatting that you've dialed in so nicely.

    Great work- wow!

    1
  • Samuel•40
    @SamuelWorld20Submitted over 1 year ago

    Hello Developers👋

    It was really a great project. I had fun making the page responsive.😄

    I'd really appreciate if you could review my project and tell me areas I'm lagging.

    🙏Thanks in advance Happy Coding😄

    QR Code Component

    1
    bonniemira•60
    @bonniemiraPosted over 1 year ago

    Hey Samuel, nice work! The first thing I noticed is that the margin around the top of the QR code isn't quite even, and I found it interesting that you used Poppins for your font instead of Outfit, but despite this you got it quite close in style. I haven't learned about Bootstrap yet, so it made it a bit harder for me to understand all your decisions, but it looks very nice. Keep up the good work. :)

    Marked as helpful
    0