@DezzaAnnePeregrinaSubmitted almost 2 years ago
Hi! this is my first challenge in frontend mentor. I am willing to take advices and comments to learn more. Thanks :)
Bryan King Pecho
@bkpechoAll comments
- @bkpechoPosted almost 2 years ago
Hey Dezza! I wanted to take a moment to congratulate you on completing your first frontend mentor challenge. It's clear that you put a lot of effort into your work and you should be proud of your achievement. You have shown great potential in your frontend development skills and I encourage you to continue pushing yourself to reach new heights.
I reviewed your project and I have to say that everything looks great! Your attention to detail is impressive, and the overall design is very clean and polished. However, I noticed that there is one thing missing: alt text for your qr code image. Adding alt text will not only make your site more accessible to users with visual impairments, but it will also improve your site's search engine optimization (SEO).
Don't worry, it's a quick fix and I'm sure you'll have it done in no time. Keep up the great work and I look forward to seeing what you create next. Happy coding!
Marked as helpful1 - @rodrigotfdevSubmitted almost 2 years ago@bkpechoPosted almost 2 years ago
First of all, congratulations on the great result of your coding! Your hard work is paying off and it shows in the quality of your work.
Regarding the HTML structure of your project, it's important to have at least one main landmark, and it would be a good idea to replace the
<div class="container"> with the <main> tag. This will make the HTML code more semantic and easier for assistive technologies to understand.Additionally, it would be a good idea to
include a level one heading or <h1> tag. The title "Equilibrium #3429" would be a great candidate for the <h1> tag, as it provides a clear and concise heading for your content.It's also important to note that all page content should be contained by landmarks, rather than just <div> elements. This will make your code more accessible and easier to understand.
That's all for now, happy coding! 🎉
Marked as helpful0 - @danyx75Submitted almost 2 years ago
I was having a hard time wither I should use <ul> or <p> where it says "0.041 ETH" and "3 days left". I also was having a hard time putting the image icon next to the text while using the flex-box method.
@bkpechoPosted almost 2 years agoHey there good job!
With the "0.041 ETH" and "3 days left", I think
it would be better to use <span>for them as they are short texts. Also, you may wrap them together with their icons in a<div> instead of an <article>I hope my feedback helps! Well done for completing this challenge. HAPPY CODING 🎉
Marked as helpful1 - @meantoesSubmitted almost 2 years ago
Hi! I had struggle on how to make the card stay on the center of the page.. and um like, when you use grid, do you give the template a value or do you use max-width? or is there any better way to do so?🥲
and is that okay to use units like vh and vw??
I'd appreciate any feedback to my code⭐🙆🏻♀️
@bkpechoPosted almost 2 years agoHey there great job!
I think what you're looking for is this. Instead of wrapping everything from .images to .creator directly with the Main. Try wrapping it all first with a div, and now you can place that div inside the main. You can then set flex to your main and easily center your card. Happy coding!
Marked as helpful0
