Skip to content
OverviewSolutions
5
Comments
3
Bisola Onaolapo
@bisoladev

All comments

  • Yari Morcus•500
    @YariMorcusSubmitted about 1 year ago

    I do not have any questions but I must say that I learned quite a lot with this project.

    A couple of things I learned are

    1. How to work with ES6 classes and modules
    2. How to work with a zero configuration build tool such as Parcel
    3. How to implement the MVC (model-view-controller) architecture in JavaScript
    4. How to implement the Publisher-Subscriber pattern
    5. How to write documentation for functions
    6. How to implement a project configuration file and use it throughout the project

    Another thing I created as well is a flowchart. This is something I learned from a previous course I followed on Udemy (so I decided to create one on my own this time).

    Feedback on the implementation of the MVC architecture as the error handling is welcome.

    ----------

    As a sidenote: as soon as the user presses the button, the button disables for 2 seconds. The API returns the same advice within that time period and this might confuse the user if the user presses the button again.

    Advice generator app (MVC architecture, ES6 classes and modules)

    1
    Bisola Onaolapo•160
    @bisoladevPosted about 1 year ago

    Great job! I would suggest adding a loading state to help the users be more patient during the latency period of 2 seconds. Other than that, I think it was an awesome work!

    Marked as helpful
    1
  • Bisola Onaolapo•160
    @bisoladevPosted about 1 year ago

    Great job! I couldn't see the code to give more observations, the GitHub link seems broken however I would say there could be some improvements in making it responsive:

    1. You could use the 'clamp' CSS property to make the text more responsive.
    2. Max-width, min-width and flex to make the card responsive on all screens.
    3. The button covers some of the text on the card, so I would say making the button absolute and the card relative would work, thereby you could give the button a position of say 50? and it would always stay relative to the card in that particular position

    PS: All the suggestions are hypothetical as I couldn't see the code however I hope it helps!

    0
  • svyatoslavkk•90
    @svyatoslavkkSubmitted about 1 year ago

    📁 Project: Advice Generator

    🔗 GitHub Repository: https://github.com/svyatoslavkk/advice-generator-app-main

    🧰 Tools and Techniques:

    React ⚛️ Fetch API 🌐 Styled Components 💅 SCSS 🎨 Responsive Design 📱 Animation 🚀 Git (Version Control) 🐙 Deployment on Netlify ☁️ 💡 Summary:

    I created an advice generator app that provides users with random advice. It's responsive and visually appealing. Users can click the dice icon to get advice, and the count increases with each new advice.

    👉 Live Demo: https://advice-generator-app-main-one-alpha.vercel.app/

    🚀 Future Improvements:

    Implement error handling 🛠️: Enhance error handling to provide a better user experience in case of API request failures. Add more interactivity and sharing options 💬: Extend the app's functionality by allowing users to interact with advice and share it on social media. Enhance the user interface and design 🎨: Improve the visual design and user interface to make the app even more engaging and user-friendly. I enjoyed building this project and learned valuable skills along the way.

    Created by using React ⚛️, Fetch API 🌐, Styled Components 💅, SCSS 🎨

    1
    Bisola Onaolapo•160
    @bisoladevPosted about 1 year ago

    Great implementation !! I love the fact that you created your own spinner from scratch The only observations I would give are:

    1. I think one divider image would be better and then adding a max width to it so that it doesn't overflow in mobile view...because your implementation though had two different images for mobile and desktop, overflows when it gets to a small-sized mobile
    2. Adding an error state, like an 'oops an error occurred message' when there is an error would be great

    Overall I think it was an awesome job

    Marked as helpful
    0