Pedro Brito• 380
@PedroBritoDEV
Submitted
Benjamin Cordier
@benoclock
All comments
- Benjamin Cordier• 60
@benoclock
Posted
Hi Perdo,
You can improve your solution by just adding few HTML attributes :
- I can fill the card number input with too much digits (add a limit to 16)
- I can set the "MM" input with 13, 14, etc. (add a range between 1 and 12)
- I can set the "YY" input with 1492 (add a range from now to next 10 years)
You can find all you need on the MDN Input Doc : https://developer.mozilla.org/fr/docs/Web/HTML/Element/input
Marked as helpful
0 - Pyaesone Khant• 230
@PK-WookiDooki
Submitted
Benjamin Cordier• 60@benoclock
Posted
Hi,
You did not handle the form submission (like pressing "enter" after writing the task). You had only handle the event "click" on the button. So, when I wrote my task and press Enter, the page is refreshed.
This is a UX mandatory feature.
Best regards,
Ben
Marked as helpful
0 - Elif Seyhan• 180
@elifseyhan
Submitted
Benjamin Cordier• 60@benoclock
Posted
Hi,
Signup button should be a <a> tag, and should change on mouse over
<main> has a single child, and no CSS attached. You should add the "container" class to <main> and delete the useless <div> child "join-content" and "green-content" should be <section> (semantic tag)Marked as helpful
0
