Skip to content
OverviewSolutions
4
Comments
4
bedende
@bedende

All comments

  • bedende•80
    @bedendePosted about 2 months ago

    Areas for Improvement Use of Colors:

    Using HSL for colors is great for manipulation. However, ensure your color choices provide sufficient contrast for readability, especially in light backgrounds. Avoid Fixed Widths:

    Instead of max-width: 40rem; for the main container, consider using relative units like percentages for better adaptability to various screen sizes. List Items:

    The <li> elements are well done, but you could consider using <ol> for ordered instructions to enhance structure. Table Structure:

    In your nutritional values section, consider using a <table> element for clarity and semantic correctness instead of <div class="tab">. Font Weight Variations:

    In the h1, h2 styles, using font-weight: 400 is fine, but you might want to consider using a heavier weight for more impact, especially for headers. CSS Organization:

    Consider grouping related styles together for better readability (e.g., all font-related styles in one section). Avoiding Inline Styles:

    Although you haven't used inline styles, be mindful in general. Keeping styles in your CSS file improves maintainability. Accessibility Considerations:

    Ensure that all images have meaningful alt text for screen readers. For decorative images, use empty alt attributes.

    Marked as helpful
    1
  • bedende•80
    @bedendePosted about 2 months ago

    You should use the <main> tag for better seo

    0
  • bedende•80
    @bedendePosted about 2 months ago

    You don't need to put the files in their own individual folders unless you have a lot of files to handle, if you keep them all in one folder then you don't need the css/ in the href when linking your stylesheet. You can also give the small picture a height and width attribute in html to make it smaller.

    Marked as helpful
    1
  • 4rd2•60
    @4rd2Submitted 2 months ago
    What are you most proud of, and what would you do differently next time?

    I am most proud of being able to get flexbox to work properly. If I had to do this differently next time I would start with centering.

    What challenges did you encounter, and how did you overcome them?

    I had a lot of challenges with how to properly start the whole project. After an hour of cluelessness I decided to come back to the project and was able to get a start in.

    What specific areas of your project would you like help with?

    I wasn't sure how to do mobile and desktop sizing. I also had trouble understanding if I was supposed to use exact measurements or use some other kind of method.

    QR-code

    2
    bedende•80
    @bedendePosted 2 months ago

    Basically exactly like the solution, impressive!

    0