Skip to content
OverviewSolutions
5
Comments
5
Ayush Kanyal
@ayushkanyal

All comments

  • Ayush Kanyal•120
    @ayushkanyalPosted 12 months ago

    Hey Diogo,

    Great Job on the website, I loved how you successfully replicated the exact design from the design starter files, you have a good eye. A small suggestion from my part would be getting rid of the arrows on the number input type. You can find the solution easily on stackoverflow. Feel free to check out my solution for the same. Cheers, Ayush

    Marked as helpful
    0
  • Ayush Kanyal•120
    @ayushkanyalPosted about 1 year ago

    Hey @Kaleb,

    Good job on the site, and love your neat arrangement of a complicated javascript code. I am a beginner myself so please do take my suggestions with a grain of salt. A few things you can still improve might be getting rid of the arrows on the number input when in focus.[a simple stackoverflow search will help]. You might also like adjusting the font family for the input placeholder-text with simply "Poppins-Bold". Would love any insights on my solution as well. Cheers, Ayush

    1
  • Ayush Kanyal•120
    @ayushkanyalPosted about 1 year ago

    Hey Eric,

    Great job on the solution. I love the simple functions you've used in your JavaScript code. I am a beginner myself so do take my review with a pinch of salt. I think a slightly bigger font size for the text in the dialogue boxes, will make them look more like the original design image. And I'd love to know how you decided on the colors because they are in hex code format. Feel free to check out my solution for the same and suggest any improvemnts.

    Best wishes, --Ayush

    Marked as helpful
    0
  • Ayush Kanyal•120
    @ayushkanyalPosted about 1 year ago

    Hey great work Tristan!

    I love how you have achieved an output with colors so close to the original design. I am a beginner myself so do take my review with a pinch of salt.

    I think a bit of padding with your button selector will make them look a little bigger and similar to the deisgn.

    And you can try breaking down the two functions in your javascript code into smaller functions.

    Feel free to review my solution for the same.

    My best wishes, --Ayush

    1
  • Ayush Kanyal•120
    @ayushkanyalSubmitted about 1 year ago

    Added main tag to contents section, alt attributes for image elements and an h1 heading to help screen readers identify the main heading of the page.

    Responsive Results-summary-page #1

    2
    Ayush Kanyal•120
    @ayushkanyalPosted about 1 year ago

    Hey Christian,

    Thank you so much for your thorough feedback! I have improved my solution because of your insights. I did the following changes:

    1. Added main tag to contents section.
    2. Alt text attributes for image elements.
    3. An h1 heading to help screen readers identify the main heading of the page.
    0