ValafarL• 170
@ValafarL
Submitted
Kentavious Reid
@aweezzy
All comments
- Kentavious Reid• 30
@aweezzy
Posted
There are only a few things that I have queries about. So in your CSS you used flex-box in your main-card class. Well in some cases that may work, but in this project I believe grid will work just fine. It is strange the way you media queried the page, I got confused by reading the non queried style tags thinking they were the desktop page. The border radius is off. you added it to both your image and your "second card" which of course gave it the full top:right:left:bottom radius. Instead I would switch to grid for your main-card and create a grid-template of repeat(1fr) so that they evenly share the element and nothing overflows. Put only border radius: 0 5px 0 5px on the image and border-radius: 5px 0 5px 0 on the "second-card".
Marked as helpful
1 - Ashwani Kumar• 230
@AshwinKumar0
Submitted
Kentavious Reid• 30@aweezzy
Posted
For the most part it looks great. Semantics and everything I like it, but why the box shadow?
0
