Hey thanks for visit my project, please give a feedback if you know how I could improve my code. Thanks :)
Luciano Sinisterra
@attrix182All comments
- @KarenFR96Submitted over 1 year ago@attrix182Posted over 1 year ago
Hola!
Muy buena solución!
Parece que no se están viendo las imágenes correctamente.
Revisando el repositorio no veo la carpeta “images”, ¿Puede ser que te hayas olvidado de subirla?
Espero que puedas solucionarlo!
0 - @MikeyABallSubmitted over 1 year ago
Really fun challenge! Allowed me to learn some new HTML to handle accessibility better and also manipulate srcset for changing images with media.
@attrix182Posted over 1 year agoHi!
Nice solution!!
You can have a better approach if set this in your
p
tag:color: hsl(228, 12%, 48%);
or better:color: var(--gry-blue)
Happy Coding!!
1 - @SecreSwalowtailSubmitted over 1 year ago
The footer is for some reason hard for me. I'll revisit this and redo it after I have more practice.
@attrix182Posted over 1 year agoHi!
Amazing solution! Congrats!
In my ultra-wide screen the background image not show properly.
I fix it adding:
"background-size: contain;"
onbody
tag.0 - @GhaidaaAl-EzziSubmitted over 1 year ago@attrix182Posted over 1 year ago
Hi! Your QR image not loaded correctly.
Try change this:
<img src="C:\Projects\html-css-app\qr-code-component-main\images\image-qr-code.png" alt="">.
For: <img src="./images/image-qr-code.png" alt="">
Marked as helpful0