All comments

• 

  Mikhil Desai•200

  @mike15395Submitted 4 months ago

  What are you most proud of, and what would you do differently next time?

  This is the first project that i have hosted on github pages, so i am proud of it.

  What challenges did you encounter, and how did you overcome them?

  Most challenging part was deploying the project to github pages. It was not working as expected on github pages so i switched to vercel and it worked fine.

  What specific areas of your project would you like help with?

  writing reponsive css using media queries.

  

  Responsive qr code challenge using flex

  2

  20
  

  atomic-variable•10

  @atomic-variablePosted 4 months ago

  Hi Mikhil,

  Congratulations on completing your first challenge. I've some suggestions that might interest you,

  1. Though you have set the exact width and height as per design, it did not reflect on the website. Because by default in the CSS box model, the width and height you assign to an element is applied only to the element's content box, padding and border will take additional space. Setting box-sizing to border-box would fix this issue for you. For detailed information, refer here.
  2. It is always advisable to add width & height to the images. Apart from matching the design, it allows the element to take up space before it loads and avoid layout shifts.
  3. I noticed a few unused styles in the head tag, it's better to remove them to avoid unnecessary load.
  4. The font import is missing from the head tag. You might need to add something like this in your code

  <link href="https://fonts.googleapis.com/css2?family=Outfit:[email protected]&display=swap" rel="stylesheet">
  

  I hope my suggestions help you, Happy coding!

  Thanks

  1