Skip to content
OverviewSolutions
14
Comments
248
Atif Iqbal
@atif-dev

All comments

  • Atif Iqbal•3,200
    @atif-devPosted about 1 year ago

    Hi, congrats🎉 on completing the challenge. Better take care about following points.

    • When we open GitHub repository link, at right side you will find an About Section. There, also include a live preview link of your project. It is better for someone to check your preview project while interacting with code.
    • Include a README file in your GitHub project's solution and write about your working flow, findings, new learned things, useful resources, etc.
    • Have seen your project in my browser(1366 * 768), container looks big. I think if you will add margin top and margin bottom on container and will make the container little bit smalller(height wise) then view will look NICE. You can also check responsiveneess for different screen sizes using LT browser(Download: LT browser)

    (Have any questions🧪?reply to this comment😇)

    --Got any questions, REPLY--

    Hope you will find this Feedback Helpful.

    Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub

    Marked as helpful
    1
  • Atif Iqbal•3,200
    @atif-devPosted about 1 year ago

    Hi, congrats🎉 on completing the challenge. Better take care about following points.

    • For better preview and centered, modify your code as:
    1. Add min-height: 100vh; in body selector inside CSS.
    2. Remove all CSS code of main selector.
    3. Add margin-top: 1em; in .attribution selector.
    .container {
  display: flex;
  border-radius: 0.5rem;
  overflow: hidden;
  border: 0.1rem solid #ebdddf;
  box-shadow: 0 0.2rem 1rem black;
  height: 25rem;
  max-width: 520px;
}
.left-side {
    background: url(images/image-product-desktop.jpg);
    background-size: cover;
    background-repeat: no-repeat;
    height: 100%;
    width: 50%;
}
@media (max-width: 525px)
.container {
    display: flex;
    flex-direction: column;
    height: 39rem;
    width: 20rem;
}

@media (max-width: 525px)
.left-side {
    background: url(images/image-product-mobile.jpg);
    background-position: center;
    background-size: cover;
    background-repeat: no-repeat;
    width: 100%;
}
    • In README file of your GitHub project's solution remove already present content and write about your own working flow, findings, new learned things, useful resources, etc.

    --Got any questions, REPLY--

    Hope you will find this Feedback Helpful.

    Let's connect for learning📝 and sharing🤝: Twitter , Instagram , LinkedIn , GitHub

    0
  • Atif Iqbal•3,200
    @atif-devPosted about 1 year ago

    Hi, congrats🎉 on completing the challenge. Better take care about following points.

    • According to requirements, your "Try it free" button 'f' should be capitalized and set the hover effect that is required.
    • There should be a curved shape before footer. Check design/image file.
    • Footer social icons are not in round shape and there is no hover effect on them.
    • You need to fix Subscribe button position.
    • Email validation is not working.
    • In responsive mode it is better to center Subscribe button and footer content.
    • In README file of your GitHub project's solution remove already present content and write about your own working flow, findings, new learned things, useful resources, etc.
    • It is preferred to use em unit for margin and padding and rem unit for font-size. Watch here.

    --Got any questions, REPLY--

    Hope you will find this Feedback Helpful.

    Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub

    Marked as helpful
    0
  • Whitney Dallas•80
    @Wdallas12Submitted about 1 year ago

    This was a good quick project to refresh my knowledge of fetching API data. It took some light research to remember how to format the fetch function but outside of that this was a smooth process!

    Any feedback is always welcome :)

    Advice Generator App

    1
    Atif Iqbal•3,200
    @atif-devPosted about 1 year ago

    Hi, congrats🎉 on completing the challenge. Better take about following points:

    • You must be seeing Accessibility Issue, generated by FEM Report Generator. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
    <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>
    • Your preview page needs to be responsive for different screens. For a better preview, centered and responsive modify your code as follows:
    body {
    background-color: var(--dark-blue);
    display: grid;
    place-content: center;
    min-height: 100vh;
}

    @media screen and (min-width: 500px)
.container-card {
    /* margin: 25%; */
    /* max-width: 600px; */
    border-radius: 20px;
    box-shadow: 1px 7px 40px rgb(21, 30, 36);
}

    .container-card {
    background-color: var(--dark-grayish-blue);
    margin: 0em 1em;
    max-width: 600px;
    position: relative;
    display: flex;
    flex-direction: column;
    justify-content: center;
    align-items: center;
    padding: 4rem 1rem 7rem 1rem;
    border-radius: 10px;
    box-shadow: 1px 3px 10px rgb(21, 30, 36);
}

    • If you are enough comfortable with CSS better learn about responsive units and responsiveness. For responsivness learning, take Conquering Responsive Layouts short course.

    • When we open GitHub repository link, at right side you will find an About Section. There, also include a description and live preview link of your project.

    • In README file of your GitHub project's solution remove already present content and write about your own working flow, findings, new learned things, useful resources, etc.

    --Got any questions, REPLY--

    Hope you will find this Feedback Helpful.

    Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub

    Marked as helpful
    0
  • Atif Iqbal•3,200
    @atif-devPosted about 1 year ago

    Hi, congrats🎉 on completing the challenge. Better take care about following points.

    • You must be seeing some accessibility issues generated by FEM Report Generator. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
    <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>
    • When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. So that someone can see project live after opening code.
    • For better preview, centered and responsive card, modify code as:
    body {
  background: var(--very-dark-blue-main);
  font-family: var(--ff-Outfit);
  display: grid;
  place-content: center;
  min-height: 100vh;
}

    .container {
  color: var(--white);
  padding: .8em 1em;
  border-radius: 15px;
  background: var(--Very-dark-blue-card);
  width: 310px;
}

    .card-img {
  height: 280px;
  border-radius: 10px;
  background-image: url(./images/image-equilibrium.jpg);
  background-position: center;
  background-repeat: no-repeat;
  background-size: contain;
}

    Remove following blocks of code:

    @media (max-width: 378px) {
  .container {
    width: 90%;
  }
}
@media (max-width: 420px) {
  .container {
    width: 85%;
  }
}
@media (max-width: 688px) {
  .container {
    width: 50%;
  }
}
@media (max-width: 1024px) {
  .container {
    width: 35%;
  }
}
@media (max-width: 378px) {
  .card-img {
    height: 280px;
  }
}
@media (max-width: 420px) {
  .card-img {
    width: 100%;
    height: 290px;
  }
}

    --Got any questions, REPLY--

    Hope you will find this Feedback Helpful.

    Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub

    Marked as helpful
    1
  • Roxana Valeria Solernou•20
    @RoxxVSSubmitted about 1 year ago

    I still have a hard time using the flex to get each element to be positioned where I want it to be. I would appreciate if you leave a comment if you find that there are better ways to carry out this project.

    QR card with flexbox

    1
    Atif Iqbal•3,200
    @atif-devPosted about 1 year ago

    Hi, congrats🎉 on completing the challenge. Better take about following points:

    • When we open GitHub repository link, at right side you will find an About Section. There, also include brief description and live preview link of your project. It is better for someone to check your live project while interacting with code.
    • Include a README.md file in your GitHub project's solution and write about your working flow, findings, new learned things, useful resources, etc.
    • There are responsiveness issues in QR-code container. For a better preview, centered and appropriate responsiveness, modify code as:
    body {
  background-color: var(--LightGray);
  font-family: 'Outfit', sans-serif;
  display: flex;
  min-height: 95vh;
  justify-content: center;
  align-items: center;
}

    .flex-container {
  background-color: var(--MyWhite);
  border-radius: 6%;
  padding: .8em .1em;
  width: 275px;
}

    .contenedor_texto {
  border-radius: 10px;
  margin: 1% 7%;
  text-align: center;
}

    Remove following code:

    @media only screen and (max-width: 600px) {
  .flex-container {
    width: 80vw;
    margin: 20% auto;
    padding: 5% 1%;
  }
}

    (When you will be enough comfortable with CSS then better learn about responsiveness and responsiveness units. You can learn responsiveness units from a free short course Conquering Responsive Layouts).

    --Got any questions, REPLY--

    Hope you will find this Feedback Helpful.

    Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub

    0
  • Atif Iqbal•3,200
    @atif-devPosted about 1 year ago

    Hi, congrats🎉 on completing the challenge. Better take about following points:

    • You must be seeing some accessibility issues generated by FEM Report Generator. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
    <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>
    • Also work on responsiveness of <div class="bottom"></div> block
    • When we open GitHub repository link, at right side you will find an About Section. There, also include brief description and live preview link of your project. It is better for someone to check your live project while interacting with code.

    --Got any questions, REPLY--

    Hope you will find this Feedback Helpful.

    Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub

    0
  • Atif Iqbal•3,200
    @atif-devPosted about 1 year ago

    Hi, congrats🎉 on completing the challenge. Better take care about following points.

    • Testimonial horizontal scroll and vertical scroll don't look good. Make it according to design
    • When we click on testimonial button above text and images change.
    • <button id="get-started">Get Started</button> hover effect not good.
    • Click on email input field then click anywhere on screen you will see invalid email message. (Invalid email message should only appear on button click)
    • Responsiveness is also not good, you need to work on responsiveness.
    • You must be seeing some acceessibily issue in code after project submission. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
    <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>
    • When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.

    --Got any questions, REPLY--

    Hope you will find this Feedback Helpful.

    Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub

    1
  • Gabriel Lira•170
    @gabrieltrtSubmitted about 1 year ago

    Hi friends, here's another finished challenge: Social Proof Section.

    I hope I can count on your valuable feedback so I can improve more and more!

    Social Proof Section

    1
    Atif Iqbal•3,200
    @atif-devPosted about 1 year ago

    Hi, congrats🎉 on completing the challenge. YOU DID WELL🌼😍. Better take care about following points📝.

    • When we open GitHub repository link, at right side you will find an About Section. There, also include project's description.
    • In README file of your GitHub project's solution remove already present content and write about your own working flow, findings, new learned things, useful resources, etc.
    • It is preferred to use em unit for margin and padding and rem for font-size. Watch Here. (and if you want to go further to understand responsive units, better explore Conquering Responsive Layouts short course).

    --Got any questions, REPLY?--

    Hope you will find this Feedback Helpful.

    Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub

    Marked as helpful
    0
  • Atif Iqbal•3,200
    @atif-devPosted about 1 year ago

    Hi, congrats🎉 on completing the challenge. Better take care about following points.

    • When we click on email field then red border show up...It is better if red border only show up when the email is invalid.
    • In error message spelling of address are wrong.
    • One social icon is not properly visible.
    • When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. A live preview link is better for someone to check your live project after reaching at project GitHub.
    • In README file of your GitHub project's solution: write about your working flow, findings, new learned things, useful resources, etc.

    --Got any questions, REPLY--

    Hope you will find this Feedback Helpful.

    Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub

    Marked as helpful
    2
  • Atif Iqbal•3,200
    @atif-devPosted about 1 year ago

    Hi, congrats🎉 on completing the challenge. Better take about following points:

    • It is preferred to use em for padding and margin and rem for font-size. Watch here
    • When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.
    • In README file of your GitHub project's solution remove already present content and write about your own working flow, findings, new learned things, useful resources, etc.
    • There should also be hover states on social icons.
    • When we open project preview page first time, just click in input field and then click on anywhere on the screen. You will see email error whereas invalid message should display on button press only.

    --Got any questions, REPLY--

    Hope you will find this Feedback Helpful.

    Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub

    Marked as helpful
    1
  • Bhawna Pandit•80
    @bhawnapandit26Submitted about 1 year ago

    My approach was to first make the body of full screen (using vh) and then add a card to it in the center both horizontally and vertically (using grid). After that I simply added the contents. Is there any better approach to this?

    Responsive page solution using Tailwind CSS

    2
    Atif Iqbal•3,200
    @atif-devPosted about 1 year ago

    Hi, congrats🎉 on completing the challenge. Better take care about following points.

    • You must be seeing some accessibility issues. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
    <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>
    • When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.
    • In README file of your GitHub project's solution remove already present content and write about your own working flow, findings, new learned things, useful resources, etc.

    Hope you will find this Feedback Helpful.

    Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn

    Marked as helpful
    1