Skip to content
OverviewSolutions
27
Comments
11
Michael Kret
@atekron

All comments

  • Michael Kret•470
    @atekronPosted over 3 years ago

    it depends, for short - rem will respect font size settings of user browser, default 16px, em size is relative to parent a container, can be useful for some cases, and px is just a pixel, kind of constant size, generally I try to stick to rem, becase it's very predictable, in contrast to em

    0
  • Michael Kret•470
    @atekronPosted over 3 years ago

    Hi, you can take a look at this https://en.bem.info/methodology/ , useful for controlling complexity and widely used in industry

    0
  • Raj Kumar Jha•40
    @Raj-k-JhaSubmitted over 3 years ago

    hi, I am facing difficulties in making the cards suitable for the desktop version. please suggest some alternates or solutions.

    Four card feature section

    2
    Michael Kret•470
    @atekronPosted over 3 years ago

    Hi, I think you need to read this - https://developer.mozilla.org/en-US/docs/Learn/CSS/CSS_layout/Introduction , it's not very long but it give you a good overview of modern css layout, and yeah for most cases you should not use float for that :)

    0
  • Michael Kret•470
    @atekronPosted over 3 years ago

    add update() call to your checkbox oninput to update price on checkbox toogle, to fix background use this: {background-position: top left; background-size: 100vw 50%;} on desktop assign text-align: left; to your .list-about

    0
  • Manuel Rivas•150
    @AngryMorrocoySubmitted over 3 years ago

    I want some feedback (obviously?), aspects that can be better, bugs I can solve, and bad practices I can avoid. Thanks c:

    Blogr landing page

    1
    Michael Kret•470
    @atekronPosted over 3 years ago

    I'm currently also doing this challenge, and very glad that I decided to use Sass and BEM for this project, after some initial hustle it's a breeze to work on my project, my longest scss file has 100 lines, rest of them about 40 lines each, so probably it's not bad idea to use sass at least.

    1
  • Michael Kret•470
    @atekronPosted over 3 years ago

    wrap your image in some wrapper and rest of content in another one, then declare your container as a flexbox, or u can use grid to position everything however you want

    1
  • Michael Kret•470
    @atekronPosted over 3 years ago

    thank you for feedback, I now switching to desktop at 1250px, at lower values it results in horizontal scrollbars

    0
  • Michael Kret•470
    @atekronPosted over 3 years ago

    thanks for commenting, it's by design this way, I wanted to give sliders some boundary, under the hood my code uses data organized into something like json and can work with arbitrary number of data entries

    0
  • Michael Kret•470
    @atekronPosted over 3 years ago

    hi, you need to adjust your media queries, because of screens less than 600px it's looks kind of bad, also I would suggest making pattern-bg.svg as a background on an image wrapper and quotes svg background on a quote text

    0
  • Karan Mishra•10
    @karanmishra0904Submitted over 3 years ago

    How do I have 50% width for the image and also keep it responsive? Also, is there any way I could have been more efficient with my css?

    Any other feedback would be appreciated. Thanks a lot.

    Flexbox

    2
    Michael Kret•470
    @atekronPosted over 3 years ago

    I would use a separate css file for my styles, and I'd rather start my design from mobile version, just because it easier to scale up

    0
  • Michael Kret•470
    @atekronPosted over 3 years ago

    you actually should not use overlay, instead set a background of the image div to soft violet ( hsl(277, 64%, 61%)) and use "mix-blend-mode: multiply" with "opacity: 0.75"

    1