Skip to content
OverviewSolutions
3
Comments
3
Ashap Bappy
@ashap-bappy

All comments

  • Ashap Bappy•50
    @ashap-bappyPosted 4 months ago

    Hi @mustaqeemCPP,

    Congratulations on successfully completing the challenge!

    Your code is well-structured, and the website works beautifully across different screens. You've done an excellent job ensuring responsiveness.

    Few areas to improve:

    • Adjust the background color of your body, which is white in your solution.
    • You didn't implement the active states of the design. Which means when you hover in the links it will turn green and the color of the text will be black. You will find the active state image in the design folder.
    • You didn't edited the README file as per your solution. It is always a good practice to have a well structured README file which helps to understand you project.

    Feel free to reach out if you have more questions or need further assistance.

    Keep up the good work!

    0
  • Ashap Bappy•50
    @ashap-bappyPosted 4 months ago

    Hello there!

    Congrats on completing the challenge! ✅

    Your solution is really impressive!

    I'm unable to view your code, It's showing 404.

    Few more areas to improve based on your preview site:

    1. Make sure the component can never touch screen edges by either giving it a little margin or giving a wrapping element (eg body) a little padding.
    2. Your card is a little bit smaller relative to the Design given. Try to adjust padding, line-height of the content elements.
    3. The active-states design has different style for box-shadow, try to add the style for hover and focus states.

    Hope that's helpful!

    Keep up the great work!

    Marked as helpful
    1
  • Omkar•20
    @OmkarShipurkar1Submitted 6 months ago
    What are you most proud of, and what would you do differently next time?

    Refreshed my CSS skills but would like to add more structured and more exactness to it.

    What challenges did you encounter, and how did you overcome them?

    first i would have to maintain the font size which wasn't that hard then i have to fix the size of my image which i figured out by setting it's width to 100%

    What specific areas of your project would you like help with?

    I would like to be precise with the margins and paddings/

    Flexbox

    1
    Ashap Bappy•50
    @ashap-bappyPosted 6 months ago

    You did great.

    0