Skip to content
OverviewSolutions
9
Comments
27
Aryan Kumar
@aryanda1

All comments

  • Aryan Kumar•390
    @aryanda1Posted over 1 year ago

    No mobile design, everything overflowing NO check for empty comment No relative time formatting able to increase or decrease score more than 1 No overlay and modal for deleting comments

    Marked as helpful
    0
  • Aryan Kumar•390
    @aryanda1Posted over 1 year ago

    Well many things were off, first of all, didnt checked single thing before submitting a new comment or editing a new comment, a empty comment. Also there was no border radius on any containers.no visible border in textarea without clicking. ANd once the reply and edit forms are open, not able to close them, without submitting, Able to increase or descrease score of any comment more than 1. Did u rushed to complete it?

    0
  • Aryan Kumar•390
    @aryanda1Posted over 1 year ago

    animations looked good, but footer was missing, in mobile version, the green line was not made vertical

    0
  • Aryan Kumar•390
    @aryanda1Posted over 1 year ago

    Well there are many issues in the frontend part, first your mobile layout is different, and many things start coming out of their parent The green line is missing in the advanced stats part The original link is not hidden , and also less padding

    1
  • guill52•160
    @guill52Submitted over 1 year ago

    I know this needs more work, but I was having a little bit of trouble implementing the tooltips for thr prices. Any advice would be helpful🙏

    Expenses Chart

    1
    Aryan Kumar•390
    @aryanda1Posted over 1 year ago

    Hey the hover effects are missing, If u are having difficulty in adding it, first make those span hidden, than use javascript to add event listener to detect hover state and make them visible,

    1
  • ezecoder•870
    @3eze3Submitted over 1 year ago

    Hello community, well first of all I want to say the following: 'working with dates is a bit of a headache', or well for me it was haha, however I had a good result.

    And also in this project I implemented a test with vitest following the TDD methodology, to create my date class, and I had good results, although it took me a little more time, it gives me more confidence in the performance of my class.

    Question:

    • Does anyone know how I can test the dom elements?

    Thanks in advance and if you have any questions or improvements on any aspect of this project please let me know in the comments. Happy coding 🍿

    Age-Calculator 🍔 (Vanilla, SCSS, TDD)

    2
    Aryan Kumar•390
    @aryanda1Posted over 1 year ago

    Didnt checked days in month Getting negative day for 31, april as well as -1 day for 30 feb Also your layout broke in my android phone, days are coming out of their parent container

    0
  • Gabriel Kalleu•30
    @IThowerSubmitted over 1 year ago

    Javascript was the hardest for me, but i got a lot of training in it and enjoyed quite a lot while learning the language and the results were quite good i think.

    I'm insure about the cap max-height and max-width in the wrapper-main and how i got to display the success message via display.

    What are the javascript frameworks that you recommend? i thought about react quite a lot.

    Frontend Mentor / Newsletter-sign-up-form using bootstrap

    1
    Aryan Kumar•390
    @aryanda1Posted over 1 year ago

    With less height your layout just breaks, the email address field along with its label detaches from its parent, the side image is also not responsive, does resizes itself according to parent. Also in the mobile version dont add border-radius to the main-container And u are serving same image in mobile version as well as desktop version. Also the list item icon are not in line with the item content ANd in moble version, there is no black background as well

    And for small projects, no framework is really needed

    0
  • Aryan Kumar•390
    @aryanda1Posted over 1 year ago

    Just want to give one feedback, sometimes the advice sent by back api, gives same advice, u can check that out and call again until new advice is supplied

    Marked as helpful
    0
  • Aryan Kumar•390
    @aryanda1Posted over 1 year ago

    Man first the main card is also vertically centred in desktop mode, Second add atleast cursor pointer to buttons, and some hover states to them atleast

    1
  • Belly•300
    @Belly606Submitted over 1 year ago

    -Hi, Guys! I Just Want to Share That I Have Completed Four card feature sectionChallenge Using Pure HTML & CSS. 💪

    • Hope You Like It💙
    • I've Found The Part of Heading Responsive Difficult
    • If You Have Any Advice to Improve My Code According to Best Practice Drop it And I Really Appreciate it 😁
    • Happy Coding For You'll ✨

    Social Proof Section

    1
    Aryan Kumar•390
    @aryanda1Posted over 1 year ago

    Bro where is the mobile version, i cant find it? I looked in the challenge page and i saw the mobile version where the rating are just below main text, but your rating are off the scrren and screen width is also quite more.

    Marked as helpful
    0
  • birkirfreyrg•30
    @birkirfreyrgSubmitted over 1 year ago

    I found it most difficult fetching the json data and doubt that I used the best methods. Also this was the first time deploying a react project using github pages, so that took some effort in figuring it out. I learned a lot solving this project that I will carry over to other project like for example breaking apart and sorting components and files.

    React.js, Node.js, CSS, HTML, JavaScript, useState, useEffect, Json.

    1
    Aryan Kumar•390
    @aryanda1Posted over 1 year ago

    Man for this tiny project do u really needed react? Also the gray color just below the image, in the crevices of the circular border doesnt looks great, THe bottom container has white color, and the spaces created by border-radius has gray color and it looks quite bad

    0
  • Aryan Kumar•390
    @aryanda1Posted over 1 year ago

    Hey your ui looks horrible after 375 px, there isnt width for u to trigger desktop mode just after 375px

    1