Skip to content
OverviewSolutions
27
Comments
24
Arsh Goyal
@arshGoyalDev

All comments

  • Arsh Goyal•940
    @arshGoyalDevPosted 3 months ago

    Hey there, nice solution

    few suggestions

    • aligning the order confirmation modal at center would be great
    • a little margin for order confirmation modal for mobile devices would be great touch
    1
  • Arsh Goyal•940
    @arshGoyalDevPosted 3 months ago

    Nice solution,

    • it would look good if the inputs were little bit bigger
    0
  • Arsh Goyal•940
    @arshGoyalDevPosted 3 months ago

    Hey there,

    few things you could improve on

    • on clicking add to cart you should start the item count by 1 instead of 0 it will enhance the user experience
    • for bigger screen instead of using justify-self: end for products, use the extra space to make the cart and products larger
    • in the cart, border for products list should be little bit lighter, that will make it look good
    Marked as helpful
    1
  • Oluwasegun Benjamin Tobi•400
    @BensaxxySubmitted 5 months ago
    What are you most proud of, and what would you do differently next time?

    That i was able to add my items to my cart and it's working the way I was told to do

    What challenges did you encounter, and how did you overcome them?

    when the pop out component that is showing on the desktop is not suppose to show on the mobile layout and some of the arrangement of mobile is different to the Desktop layout, it was really hard for me to get, but I keep trying and I am happy I was able to overcome it

    What specific areas of your project would you like help with?

    i don't know yet, but if my bosses check it out and see what I need to do, please I will be glad if the feedback can come in

    ReactJs and TailwindCSS

    1
    Arsh Goyal•940
    @arshGoyalDevPosted 5 months ago

    Hey, it's a great solution

    few things you could improve on

    • increasing padding in the header and product info would make it look better
    • making the picture a bit smaller would make it more close to the design
    • and as a addition clicking on checkout btn can clear the cart and showing a message like checkout complete
    Marked as helpful
    0
  • Arsh Goyal•940
    @arshGoyalDevPosted 5 months ago

    Very amazing solution,

    • sign in is a great addition,

    • you could also add overflow: scroll; to todo's container to make it look even better

    Marked as helpful
    1
  • Arsh Goyal•940
    @arshGoyalDevPosted 5 months ago

    hello 👋 Dmitry,

    couple of tips,

    • for mobile menu, you could add a background overlay to separate the menu from the rest of the website
    • for bigger devices instead of using max-width: 1470px use padding to make it better
    0
  • Arsh Goyal•940
    @arshGoyalDevPosted over 2 years ago

    You have done it great

    • It seems like your solution could work but you could use "%" instead of pixels.
    • And to fix some of the accessibility issues you should either remove all of the ids you added in amount div or you could add them like id="monday amount", id="tuesday amount" and more
    1
  • Arsh Goyal•940
    @arshGoyalDevPosted over 2 years ago

    There are a quite a few issues in your solution,

    • It's not responsive.
    • There is no navbar for small devices.
    • Logo section is overflowing on the learn more btn.
    • When one dropdown menu is open and I try to open another the previous should be automatically closed.
    • The box shadow of the dropdown menu should be smooth, it could be something like this box-shadow: 5px 5px 40px rgba(200, 200, 200, 0.4)
    Marked as helpful
    0
  • de-sipher•160
    @de-sipherSubmitted over 2 years ago

    Two things; 1) Managing multiple CSS/ JS files for different HTML files is quite difficult and I need to find a more scalable way to approach this problem. 2) Speed. The fetching and loading takes a considerable amount of time which I need to find a way to reduce. The images, the filtering and the querying are the major culprits. My best guess is to take all the data from the API and store it as a local object or in a custom asset folder which will be updated every now and then.

    REST Countries API with VANILLA JS!! (✌ﾟ∀ﾟ)☞ (No React App Used)

    1
    Arsh Goyal•940
    @arshGoyalDevPosted over 2 years ago

    It's great but a few fixes would make it better:

    • Title in the navbar should be a link to the home page.
    • There are no commas in the population number that make it hard to read you could use regex to fix it
    1
  • Arsh Goyal•940
    @arshGoyalDevPosted over 2 years ago

    Great work, It could be more great if you just center align the calculator.

    Marked as helpful
    1
  • Arsh Goyal•940
    @arshGoyalDevPosted over 2 years ago

    There are some issues in the app:

    • User cannot add items to the cart.
    • Lightbox functionality is not there.
    • No control buttons for the image carousel on mobile devices.
    • You should make the mobile nav menu opaque so it's visible.
    • You should improve the navbar for the bigger devices (desktops or laptops).
    1
  • Jimmy Hoang•750
    @JimmyHoang296Submitted over 2 years ago

    My friend said to me: "Done better than perfect" So here it is, my first intermediate solution. I have a lot of problem with it:

    • messy JS code, bad managing function, I think I should group some function to make it more readable
    • still not know how to move the cursor to the end of comment box,

    any advice would be valuable to me. Thank you.

    interactive comment section with messy javascript

    1
    Arsh Goyal•940
    @arshGoyalDevPosted over 2 years ago

    There are a lot of issues in the app:

    • When I add a comment, the added comment layout is messed up.
    • When I try to reply to a comment, the comment content is in all blue (only username should be in blue),
    • I can't add a reply to a reply- The user should be allowed to upvote a comment only once,
    • And after I add a comment and try to upvote or downvote other comments it doesn't work.
    • You should remove all of the console.log() in the js file.

    All the other features are working well, and it would be nice if you add some animations

    Marked as helpful
    0