Skip to content
OverviewSolutions
3
Comments
18
Arber Lisaj
@arberlisaj

All comments

  • Muhammad Waleed Ahmed•270
    @WDWaleedSubmitted about 1 year ago

    I'm having trouble deploying my project to GitHub pages. My project shows up just fine on Netlify but on my GitHub pages site for this project, a blank page is shown to me with this error logged into the console: Loading module from “https://wdwaleed.github.io/Advice-Generator-App-Frontend-Mentor/src/main.jsx” was blocked because of a disallowed MIME type (“text/jsx”)

    ReactJS and TailwindCSS Advice Generator App

    1
    Arber Lisaj•340
    @arberlisajPosted about 1 year ago

    Hi there

    • I had the same problem when first started learning react, this problem is caused because of vite bundler. I have a github repo on how to solve this it will only take you a couple of minutes repo link
    Marked as helpful
    1
  • Arber Lisaj•340
    @arberlisajPosted over 1 year ago
    This comment was deleted about 1 year ago
    0
  • Arber Lisaj•340
    @arberlisajPosted over 1 year ago

    Hi @oyasumibella 👋 First I would like to congatulate you on compleaging the Tip Calculator App🧮 and "The entire JavaScript" you said that had me burst out laughing 😂anyways would like to share with you a couple suggestions to improve your solution

    • JavaScript: Never name your variables like this $resetBtn it should be a cleaner and more readable like resetButtonEl or just resetBtnEl
    • JavaScript: Instead of using const like a million times you want to declare your variables like this const firstName = 'Jane' , lastName = 'Doe' , age: 120;
    • UX: If you will work on responsiveness again please make it so it is more repsonsive to smaller screens so i test my websites on an iphone 8 around 370px wide and this solution it is not as good of a UX as on a larger screen like my laptop
    • GitHub: You want to remove the unused files and directories from your github repo like : designes , README-template.md etc

    All in all Great solution 🎉 and i wish you a long time in the community😊

    Happy Coding :)

    Marked as helpful
    1
  • Arber Lisaj•340
    @arberlisajPosted over 1 year ago
    This comment was deleted over 1 year ago
    1
  • Arber Lisaj•340
    @arberlisajPosted over 1 year ago

    Hi @hillarionCodes I would like to congratulate you on completing the Results summary component and I might have a couple suggestions regarding your solution

    • A semantic element clearly describes its meaning to both the browser and the developer so instead of spamming a bunch of divs it would be a lot better to use semantic elements like for example <div class="container"> should be replaced with <section class="container"> or even <main class="container"> and instead of <div class="result"> you want to use <section class="result">
    • In the right container where the results are displayed you want to add some padding so the button doesn't touch the border it would be a lot more aesthetic from a designers eye

    All in all good solution and i wish you a long time in the community

    Happy Coding :)

    Marked as helpful
    0
  • Danielle•160
    @dfeeney96Submitted over 1 year ago

    I would like to know if there are any parts of my code (particularly the JS) that I could improve on. Are there any best practices I have missed or ways to make my code more readable / efficient?

    Thank you!

    Age Calculator with Vanilla JS

    1
    Arber Lisaj•340
    @arberlisajPosted over 1 year ago

    Hi @danielle I would like to congratulate you on completing the Age Calculator App and I might have a couple quick solutions for your questions

    • Instead of declaring constant variables like this: const dayLabel = day; const monthLabel = month; etc. You want to declare them like this const dayLabel = day , monthLabel = month , yearLabel = year;
    • I see you use function keyword inside methods for an instance forEach(function(monthOfYear) it would've been a lot better if you used arrow like this monthsOfYear.forEach(m=> if(m.month === selectedMonth) // return something)

    All in all good solution and it would be a lot better if you remove the designe directory from you github repo as it is just a liability and it takes space for no good purpose

    Happy Coding :)

    Marked as helpful
    1
  • Arber Lisaj•340
    @arberlisajPosted over 1 year ago
    This comment was deleted 11 months ago
    0
  • Arber Lisaj•340
    @arberlisajPosted over 1 year ago
    This comment was deleted over 1 year ago
    0
  • Arber Lisaj•340
    @arberlisajPosted over 1 year ago

    Hi fellow developer :) ! First I would like to compliment you on completing this challenge and a warm welcome to the community

    I might have a couple of suggestions that might help you in the future :

    • You want to use as much semantic html as possible for instance <div class="card"> could be replaced with <main class="card"> or <section class="card">
    • Also the naming of the css variables should not start with capital letter it would be better if it was just --lightGray-clr ofr --light-gray-clr

    All in all great solution I hope you have a great time in the community. Happy coding!

    Marked as helpful
    0
  • regret546•450
    @regret546Submitted over 1 year ago

    I am pleased with the results of my third challenge on Frontend Mentor. It would be great if someone could review my code and provide feedback on any redundant elements or suggestions for writing cleaner code.

    Results summary component using Flexbox and Grid

    1
    Arber Lisaj•340
    @arberlisajPosted over 1 year ago

    Hi fellow developer ! First of all I have a couple suggestions about the designe and the folder structure although your solution looks clean

    • You want to use a bit more padding on the right container to make it look a bit more eye pleasing
    • In the GitHub repo you want to delete the designe folder and the readme guides to save up space and for cleaner folder structure
    • Instead of spamming a bunch of divs you could use semantic elements like article section and aside just to make an example

    All in all great solution i appreciate the effort you are putting into this industry and keep coding I am with you :)

    Happy Coding !

    Marked as helpful
    0
  • Cassia Moraes•130
    @cassialitySubmitted over 1 year ago

    Hello!!

    I worked hard to make this app, I know is simple but I did my best.

    Please, all suggestions are welcome!

    Age Calculator App

    2
    Arber Lisaj•340
    @arberlisajPosted over 1 year ago

    Hi Fellow Developer :) ! First of all I would like to congratulate you on completing the Age Calculator App and i would like to make a couple of suggestions to fix some bugs and boost your productivity:

    • The Input Element Outline is still red even if no value is provided
    • Calculated Data stacks on top of each other and that might be a css error it would be better if you put both in a div and used flexbox
    • You can remove the input type number arrows click here for more information

    All in all Great Solution and Keep Learning React

    Happy Coding !

    Marked as helpful
    1
  • Arber Lisaj•340
    @arberlisajPosted over 1 year ago

    Hi Fellow Developer I want to congratulate you on completing the Product Review Card and also i had a couple of suggestions that might help you in the future:

    • You dont want the css files all over the place it would be way better if it was organised it its own directory/folder for example a css or styles folder
    • It would be better if you provide a link in your repository readme for better accessebility github pages might help you a lot !

    All in all Great Solution | Keep up the Amazing work

    Happy Coding :)

    Marked as helpful
    0