@OlafZiorko
Submitted
Suggestions and comments are welcome.
Looking to hire developers?
@antonADev
@OlafZiorko
Submitted
Suggestions and comments are welcome.
@antonADev
Posted
Hi Olaf... First of all congratulations for finishing the challenge 🎉. The overall work is pretty amazing and you've did a great job, there are just some minor design differences:
As for your ul element, you don't need a role attribute for it, it's a semantic element and since roles are used to provide a structural description for a section of content, most of these roles should no longer be used as browsers now support semantic HTML element with the same meaning
As for the design, like I've said, your work is pretty amazing. Just check some colors of the given design and your project will be perfect. Impressive job done.
Again, it's an amazing try, this challange is not easy at all and you have to be proud of your achievement.
Hope my answer will help you to improve your skills and keep coding 😊
Marked as helpful
@aminaNBA
Submitted
I used HTML 5 / SCSS / JS in toggle button the website is responsive any insight on this, it would be great.
@antonADev
Posted
Hi Amina... First of all congratulations for finishing the challenge 🎉. The overall work is not bad on desktop size, but there are some issues and the mobile-layout isn't working at all, so I will try to give you some advices:
<body>
<header>HEADER CONTENT</header>
<main>MAIN BODY CONTENT</main>
<footer>FOOTER CONTENT</footer>
</body>
So I would suggest to refactor your code and use the semantic tags. You could also use divs giving them a role attribute, that is perfectly fine. But a semantic element like your <nav> doesn't need a role attribute, but if you use a div as a landmark purpose, then you have to use the role attribute.
As for the design, even if on desktop it doesn't look bad, the mobile-layout is missing completely. I've took a look at your code and you've used media queries, and thats amazing. Go inspect your site and with the existing media queries, just making some changes, you will achieve it.
Check for your font styling, because you're using only the regular variant.
The navbar logo isn't showing, check your src attribute.
Overall it's an amazing try, this challange is not easy at all and you have to be proud of your achievement.
Hope my answer will help you to improve your skills and keep coding 😊
@IanMcbull
Submitted
I'd like some feedback on my JS. I feel that I can improve on it and write more DRY code.
@antonADev
Posted
Hi Ian... First of all congratulations for finishing the challenge 🎉. The overall work is not bad, but there are some issues:
<body>
<header>HEADER CONTENT</header>
<main>MAIN BODY CONTENT</main>
<footer>FOOTER CONTENT</footer>
</body>
As for the design, like I've already said, the overall work is not bad, but there are some parts that can be perfectioned:
Hope my answer will help you to improve your skills and keep coding 😊
Marked as helpful
@titouanck
Submitted
@antonADev
Posted
Hi Titouan... First of all congratulations for finishing the challenge 🎉. The overall work is pretty amazing, there are just some minor issues:
But again, very impressive work and you have to be proud of yourself.
Hope my answer will help you to improve your skills and keep coding 😊
Marked as helpful
@chetanachaudhary
Submitted
@antonADev
Posted
Hi Chetana... First of all congratulations for finishing the challenge 🎉. The overall work is not bad, but there are some issues:
<body>
<header>HEADER CONTENT</header>
<main>MAIN BODY CONTENT</main>
<footer>FOOTER CONTENT</footer>
</body>
As for the design, like I've already said, the overall work is not bad, but there are some parts that can be perfectioned:
Hope my answer will help you to improve your skills and keep coding 😊
Marked as helpful
@CodeXMalinga
Submitted
@antonADev
Posted
Hi Malinga... First of all congratulations for finishing the challenge 🎉. No much to say to your work, very impressive.
Just some accessibility improvements:
Remember, it’s best practice to structure your page with HTML5 reference elements (nav, header,main,footer…)
Hope my answer will help you to improve your skills and keep coding 😊
Marked as helpful
@kristine0221
Submitted
@antonADev
Posted
Hi Kristine... First of all congratulations for finishing the challenge 🎉. The overall work is not bad, but there are some issues:
<body>
<header>HEADER CONTENT</header>
<main>MAIN BODY CONTENT</main>
<footer>FOOTER CONTENT</footer>
</body>
So I would suggest to not nest the <header> element as a child of the <main>.
As for the design, like I've already said, the overall work is not bad, but there are some parts that can be perfectioned, but overall it's very impressive.
Hope my answer will help you to improve your skills and keep coding 😊
Marked as helpful
@ProgrammerMohaimin
Submitted
Notification-page Completed, How is it ?
@antonADev
Posted
Hi Mohaimin... First of all congratulations for finishing the challenge 🎉. The overall work is not bad, but there are some issues:
As for the design, like I've already said, the overall work is not bad, but there are some parts missing:
Hope my answer will help you to improve your skills and keep coding 😊
@Lino-OTM
Submitted
Any improvements are welcome!
@antonADev
Posted
Your work is very impressive. Just some minor UI differences but still a very good job. The thing I can suggest is that <main> and <header> are intended to be at the same level of hierarchy in the page (one level below <body> ). Nesting one inside the other would therefore not be recommended. But overall, very impressive. Good job :)
Marked as helpful