TCO932• 220
@TCO932
Submitted
Bart Feesley
@antimatterhut
All comments
- Bart Feesley• 220
@antimatterhut
Posted
Very nice job! I wish I could have used the radio input on mine.
0 - nco0305• 10
@nco0305
Submitted
What are you most proud of, and what would you do differently next time?
The way how it turned out
What challenges did you encounter, and how did you overcome them?
I could not use and centre the flex box, so I tried the grid as an alternative.
What specific areas of your project would you like help with?
Any other alternative ways to create the same component? I can't figure out why the image shows broken in GitHub live page link.
Bart Feesley• 220@antimatterhut
Posted
When I preview your site, the qr picture does not show up.
0 - Peter Godspower• 470
@TheBeyonder616
Submitted
What are you most proud of, and what would you do differently next time?
Using OOP to create the APP
What challenges did you encounter, and how did you overcome them?
I used Input type = "text" at first instead of number, it made me write unnecessary function
What specific areas of your project would you like help with?
Any Feed back on my JavaScript would help..
Bart Feesley• 220@antimatterhut
Posted
There are some issues, overall its pretty good though. On desktop, your error message overlaps your "number of people" text. I also think the calculations are wrong. The bill is supposed to be split between the people. So like lets say 100 dollars is the bill, and theres 2 people. Each person would pay 50 dollars. If the tip is 10%, then they would have to split that tip too, so each person would have to tip 5 dollars, so they would end up paying 55 dollars each. Just a few minor things, maybe theres more, but those are the issues I saw right away. I really like the text shadow on hover btw, it make it pop out.
Marked as helpful
0 - mtrenkina• 50
@mtrenkina
Submitted
Bart Feesley• 220@antimatterhut
Posted
Looks good.
0 - Chidra20• 20
@Chidra20
Submitted
Bart Feesley• 220@antimatterhut
Posted
I can't access your website.
0 - MobinZ16• 40
@MobinZ16
Submitted
Bart Feesley• 220@antimatterhut
Posted
Your program is not responsive to mobile.
0 - Philipp• 130
@Obom23
Submitted
What challenges did you encounter, and how did you overcome them?
I had problems with the responsive design for the mobile version. It still does not work correctly, scrolling its not possible.
What specific areas of your project would you like help with?
Any feedback is appreciated, maybe some tips how to structure the js-code
Bart Feesley• 220@antimatterhut
Posted
The success page doesn't repeat the email I inputted back to me in the message. Other than that, good job.
1 - dhruvsaini83• 30
@dhruvsaini83
Submitted
Bart Feesley• 220@antimatterhut
Posted
Your website does not take me to the success page on desktop or mobile, and its not really responsive(doesn't scale down to mobile well). The picture is off on mobile.
Upon furthur inspection, I didn't find a js file on your code. This is a js focused challenge.
Please put more time into this one. You didn't complete this.
0 - Yohannes-GitHub• 90
@Yohannes-GitHub
Submitted
What are you most proud of, and what would you do differently next time?
What I would do differently next time would be to properly check both the desktop and mobile designs and think of a plan to execute both.
What challenges did you encounter, and how did you overcome them?
The bottom writer component would be hidden when the share button was clicked in the mobile design but would not be hidden in the desktop design. I overcame this challenge by conditionally rendering and hiding the divs based on screen size in Javascript.
What specific areas of your project would you like help with?
How to write cleaner CSS and JS code.
Bart Feesley• 220@antimatterhut
Posted
I mean I mine isn't any better. Good job.
0 - LucasNgTg• 190
@LucasNgTg
Submitted
Bart Feesley• 220@antimatterhut
Posted
On my screen, which is a pretty big 1920x1080 screen, your divs arent centered. They dont align with the title and are off to the left.
1 - Mateus• 60
@mateusxczw
Submitted
Bart Feesley• 220@antimatterhut
Posted
Shoot, much less code and simpler than mine. Good job!
1 - Divyanshu Tiwari• 110
@Tiwari0808
Submitted
Bart Feesley• 220@antimatterhut
Posted
I think you should redo this one or spend time reworking alot of this. The CSS code seems very complicated, with some elements having 11+ properties. You did 2 things somewhat correctly here, in that you have a mobile version that looks kinda like what they wanted, and you have the general *shape of the desktop version in that you have the picture on the side with the text to the right. The code completely breaks between 375 and 1440 px. Also, you should try to make the code look exactly like the original, or pretty darn close. The desktop needs a bunch of stuff moved around and styled diferently, the mobile needs a few adjustments. I would do some research on how media queries work bc I think you might have a fundamental misunderstanding there. Once more, as I make my screen larger between mobile to fullscreen, the code completely breaks. Best of luck, hope you retry it, or edit it to make it better.
Marked as helpful
0
