All comments

• 

  P

  Zachary Campanelli•390

  @ZacharycampanelliSubmitted about 1 year ago

  First project using react router, any feedback on that or in general is much appreciated!

  

  Planet Fact Site using React and Sass

  1

  60
  

  anthony•60

  @anthonydwanPosted about 1 year ago

  Really clean! I like how you structured your code.

  1. Though it looks like the surface geology is not rendering the images as shown in the design? You should be able to dynamically create additional element to render the two images.
  2. There's opportunity to refactor - e.g. the three jsx for pages and utils are of the same structure.

  Nicely done :)

  0
• 

  Iwan Kurniawan•50

  @iwan-14Submitted about 1 year ago

  I have difficulty when making the project responsive, when the responsive display is right, there is an excess white part on the right which makes the display not good.

  

  Responsive Result Summary Component

  1

  60
  

  anthony•60

  @anthonydwanPosted about 1 year ago

  Great work so far. May not be the best solution but one quick fix to suggest - when you go on inspector mode, you can see that your .card-container div is not taking the full width of the card (600px). You can specify that class to take width 600px in desktop and adjust for mobile mode. This will eliminate that white bar on the left of your result section in desktop mode.

  Keep it up!

  Marked as helpful

  1