@mdnaimurSubmitted about 1 month ago
Anh
@anhnguynAll comments
- @anhnguynPosted 5 days ago
Hello :) I came across your solution and we actually use the same libraries for the challenge!
There are some suggestions I have, you can have a look :D
- Please add alternative text for images and avoid having empty attribute values. You can delete unnecessary attributes like width and height in some images.
- The picture isn't cropped in PC view and its container isn't squared. How about using object-position and aspect-ratio properties?
I hope you find it useful! 😄 Keep going 💪
0 - @brandonmartinoSubmitted almost 2 years ago
- It was very difficult for me to know what values to use by just looking at an image. I think using a Figma file would have sped up my process tenfold.
- I wasn't sure how to approach the desktop version of this first challenge. To me, they looked identical and the .md file did not specify an increase in font size or scale.
- I would like some initial feedback on my code structure or overall design accuracy. Looking for areas that I need to improve on for my next challenge.
@anhnguynPosted 5 days ago-
You can use the Perfect Pixel extension as a workaround to match the design.
-
It seems like your code doesn't cover the whole page. You can consider setting the min-height of body to 100dvh (refer to https://ardislu.dev/min-height-100dvh).
0 - @tris6Submitted 5 days agoWhat are you most proud of, and what would you do differently next time?
Really enjoyed this exercise's problem-solving. Surprisingly, I found the JS relatively simple compared to several CSS points I got stuck on. The elegant layout hides some tricky selection challenges that took some Googling and trial-and-error.
The share icon caused me to learn how to change a child based on hovering a parent. Like everything, easy when you know how.
I was also very proud of my lateral problem-solving when I found the pop-up share bar wasn't translating well in portrait view. Instead of obsessing over local properties, I took a step more global, to realize I set the bar as a child of the share icon, rather than child of the card's footer. I would normally spend an hour driving myself crazy in the local div, but was proud to think literally 'outside the box' to find the cause. Not long ago, this would have taken me an hour, now it took me 5-10 minutes.
What challenges did you encounter, and how did you overcome them?My image sizing and cropping is still very awkward. I'm never sure whether to work with the image itself or make it relative to container. The Every Layout intrinsic sizing properties helped me out a lot with the cropping.
The share bar shape was a really fun problem-solving exercise. I tried to draw the shape in polygon but couldn't navigate the rounded corners. Eventually I decided to make it a composite of two divs: one rounded box, and one polygon triangle, joined together using absolute positioning. It did feel very hacky fine-tuning the pixel perfection, but happy with the result.
What specific areas of your project would you like help with?I'm still very unsure how best to handle SVGs in a modular way. I wanted to keep the icons in external files, and tried a few src and object properties to embed them, but could not get CSS to modify the embed. I eventually gave up: copy-and-pasted SVG paths straight into the HTML, and select svg from there.
Looking at Stack Overflow, it seems like many are struggling with the same issue. There seems to be a lack of established best practice for modular SVG work without long-winded JS work-arounds. So, not really sure.
@anhnguynPosted 5 days agoWow, I enjoy reading your progress log here! I did the same challenge yesterday, and gotta say I wish my HTML were as clean as yours :)
- For the arrow, you can look up pseudo elements in CSS and create it with :after.
- For the SVG, I actually use SVG sprites. I don't think it's the best way, but the syntax is cleaner and the performance is better than copying and paste SVG directly into the HTML.
Hope we can share some feedback about this challenge!
0
