It was a nice and easy project. Front-end mentor improved my coding skills, I can build faster than before and thanks for the kind community here. We all can grow together. Just keep learning!π
Ana Luz Cervantes
@analuzcervantesAll comments
- @tushar416Submitted over 3 years ago@analuzcervantesPosted over 3 years ago
Hi! π
It looks great, congratulations!
Just add
aria-label
to your inputs to fix accessibility issuesBe well! π»πΎ
1 - @fytrwSubmitted over 3 years ago
Hi! π It's my first project here and one of my first projects at all. I didn't know how to correctly display svgs in this project. I tried as a background-image but it didn't work so I pasted svg tag. Also, I had difficulty with placing svgs with top, left, right, and bottom and I used media for mobile. It'll be great to hear some feedback from you.
Thanks in advance! π
@analuzcervantesPosted over 3 years agoHi! π
Welcome to the frontendmentor community! π
Why don't you try to put your svg in the body in your style file, it would be something like this:
background-image: url(/images/bg-pattern-top), url(images/bg-pattern-bott);
For the position you can use
vw
andvh
background-position: right 50vw bottom 50vh, left 50vw top 50vh;
Here I leave you more information about vw and vhBe well! π»πΎ
2 - @NadyaMumtazahSubmitted over 3 years ago
Love to hear your feedback!
@analuzcervantesPosted over 3 years agoHi! π
Welcome to the frontendmentor community!
I would just like to give you some tips:
- For the background images
bg-pattern-top
andbg-pattern-bottom
, I recommend placing it in the body on stylesheet filebackground-image: url (), url ();
For the position you can usevw
andvh
background-position: right 50vw bottom 50vh, left 50vw top 50vh;
Here I leave you more information about vw and vh - For your user profile class you can use
display: flex; justify-content: space-evenly;
I leave you a Flexbox guide - Check the Accessibility issues and HTML issues report and try to fix them
Be well! π»πΎ
0 - For the background images
- @BarabazsSubmitted over 3 years ago
Any constructive feedback is appreciated. Don't hesitate to get in touch.
@analuzcervantesPosted over 3 years agoHi! π
I like it a lot, especially the label effect. Congratulations!
It also adapts very well to all devices!
Be well, keep coding!
1 - @mbaronsSubmitted over 3 years ago
I think I'm using too much of relative positions, I'm not sure that is a good practice. Can someone take a look please?
@analuzcervantesPosted over 3 years agoHi! π
Welcome to the frontendmentor community! π
I would just like to give you some tips:
- For the background images
bg-pattern-top
andbg-pattern-bottom
, I recommend placing it in the body on style filebackground-image: url (), url ();
- For the position you can use
vw
andvh
background-position: right 50vw bottom 50vh, left 50vw top 50vh;
Here I leave you more information about vw and vh - Check the Accessibility issues and HTML issues report and try to fix them
Be well, keep coding! π»πΎ
2 - For the background images
- @DcatnisSubmitted over 3 years ago
HI, here I use some JS any comment are wealcome!
@analuzcervantesPosted over 3 years agoHi! π
Your solution is amazing!
Just a tip, did you see that white border in the background? To fix it change your background-color in the body
Also try to fix the HTML accessibility report
Be well, keep coding! π»πΎ
2 - @nainpreet-05Submitted over 3 years ago@analuzcervantesPosted over 3 years ago
Hi! π
Welcome to the frontendmentor community! π
I would just like to give you some tips:
- For the background images
bg-pattern-top
andbg-pattern-bottom
, I recommend placing it in the body on style filebackground-image: url (), url ();
- For the position you can use vw and vh
background-position: right 50vw bottom 50vh, left 50vw top 50vh;
Here I leave you more information about vw and vh
Be well! π»πΎ
1 - For the background images
- @esardilaSubmitted over 3 years ago@analuzcervantesPosted over 3 years ago
Hi! π
It looks great!
Just a little tip, leave a margin top for mobile versions, so the image doesn't get cut off. And leave a margin top for attribution class that way it doesn't cover the questions and answers.
Be well! π»πΎ
3 - @TofuSupremeSubmitted over 3 years ago@analuzcervantesPosted over 3 years ago
Hi! π
Incredible, your design is very responsive and the validation works perfectly!
Congratulations!
Be well, keep coding! π»πΎ
3 - @Harold-kunSubmitted over 3 years ago
Any feedback is appreciated.
@analuzcervantesPosted over 3 years agoHi! π
Welcome to the frontendmentor community! π
For your first challenge, it's pretty cool. But it is not responsive, flexbox or grid could make it easier.
I'm going to leave you two articles that can help you to carry out this and future challenges:
- [Flexbox] (https://css-tricks.com/snippets/css/a-guide-to-flexbox/)
- [Grid] (https://css-tricks.com/snippets/css/complete-guide-grid/)
Be well, keep coding! π»πΎ
4 - @kairemersonSubmitted over 3 years ago@analuzcervantesPosted over 3 years ago
Hi! π
I quite like your design and it is very responsive. Congratulations!
Be well, keep coding !π»πΎ
4 - @FaizzySubmitted over 3 years ago
The icons are not in perfect circle in mobile view, Need a fix
@analuzcervantesPosted over 3 years agoHi! π
Add to the class
.icons i
awidth
of50px
andheight
of50px
Also add a hover class for your register button, for when the user hovers the button color changes to hsl (300, 69%, 71%)
Lastly, check your HTML issues report and try to fix them
Be well, keep coding! π»πΎ
3