@zs-kevSubmitted over 4 years ago
Any constructive feedback is welcome.
Samy
@anaielAll comments
- @anaielPosted over 4 years ago
Good job, the design is very neat! This is coming from s/o without actual experience, but from what I've gathered around the web in terms of accessibility, it is better to leave an empty alt attribute for images which do not add meaning (such is the case for the icons here). Also, I would add a h2 heading to make sure the structure is ok (you can hide it by making sure its position if off screen) Also, is there a reason to chain all the class selectors ? It probably doesn't have a huge impact here but since selectors are read right to left anyway, it feels like it forces the browser to make unnecessary checks (since all the .icon are within a .icon-container are within a .card-container are within a .card.
1
