All comments

• 

  Jawaad•100

  @jaawSubmitted almost 3 years ago

  Hi ! I can't make my media query worked i don't understand what i've done wrong. If someone can help me with this one please . Thx

  

  QR Code Challenge

  4

  40
  

  Amish Verma•25

  @amishvermaPosted almost 3 years ago

  Hey Jawaad,

  1)First of all, you did a good job in achieving the design. If you are working for responsiveness then try using relative units of CSS that is rem or em instead of px.

  2. You could have used the display flex property instead of adding too much margin which affects the overall responsiveness.

  0

  This comment has received 2 repliesShow
• 

  Shruthi Reddy Kolan•10

  @shruthireddyySubmitted over 3 years ago

  It would be great if You all could tell me where to improve as I am just a beginner.

  Also Some advice and help on positioning of elements would be great too

  

  I used Visual Studio Code

  2

  21
  

  Amish Verma•25

  @amishvermaPosted over 3 years ago

  Hello Shruthi,

  First of all, as a beginner, you have done a really good job. There are few things that you will need to note in the particular challenge

  • You need to work on the responsiveness as well as the background color mentioned above.
  • You have to add an overlay just to the image.
  • In terms of using units try to use more relative units such as **rem or **em instead of **px
  • In terms of position there is a good video of how and when to use position by [WebDevSimplified] (https://www.youtube.com/channel/UCFbNIlppjAuEX4znoulh0Cw)
  • In case of any more doubts feel free to contact

  All the best

  1