All comments

• 

  André Barbosa•40

  @andrebdasilvaSubmitted over 2 years ago

  I don't know if I coded correctly, I have doubts about good practices?

  

  Product preview card component - HTML, CSS

  1

  60
  

  Amir•220

  @amirintechPosted over 2 years ago

  You did well but I guess there is two points where can improve:

  • Instead of loading two images for the product image in your html file and then manually showing and hiding them using css and media queries, you can use the html <picture> tag to achieve the same functionality and without using CSS.

  • In your CSS file, if you have some styles that are common and shared by a number of elements, you can just add those styles to the body element and then its children will inherit those styles due to the cascading nature of CSS. So, as a best practice define your font family, color, and similar styles to the body element.

  Hope this was helpful :)

  Marked as helpful

  2

  This comment has received 3 repliesShow