Skip to content
OverviewSolutions
36
Comments
2
ali
@alishirani1384

All comments

  • Greatemmet•20
    @GREATEMMETSubmitted about 2 years ago

    it was difficult working with the desktop image, as i was trying to fit it into a 500px height container. i set the height of the image to be 100% but it ignored the height container and maintained its predefined height. Tried different values, went back and forth my code to see of i made any mistakes but i found nothing. i later had to set the container to take the height of the image. if there is a way around this, i'd really love to know.. All feedbacks are welcome...

    responsiveness was done with flexbox

    3
    ali•540
    @alishirani1384Posted about 2 years ago

    Hi @GREATEMMET you did a very excellent job on this challenge to make it center both vertically and horizontally you can add this code to your body: body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; flex-direction: column; }

    Marked as helpful
    0
  • ali•540
    @alishirani1384Posted about 2 years ago

    Hi there you did an excellent job on this challenge, there are a few pieces of advise for making it better. 1_ use the font-family specified in style.guide.md file. 2_ use the min-height:100vh in your body styles to make it center.

    my YouTube channel: https://www.youtube.com/channel/UCqJxABBuzx4vj_RxogCbAFA

    0