Skip to content
OverviewSolutions
5
Comments
3
Ali Sariyer
@alisariyer

All comments

  • Victor•290
    @cervantesdeveloperSubmitted over 2 years ago

    How do you make responsive text? I mean, do you use a font-size relative to the viewport width like font size: 5vw? or do you set the font size on each brackpoint?

    Responsive summary card

    2
    Ali Sariyer•160
    @alisariyerPosted over 2 years ago

    Hi Victor,

    Nice work. I use this technic for responsive font:

    1. Use a variable as --rem: 1rem in :root or html selector
    2. For any element you can use like: h1: { font-size: calc( var(--rem) * 1.4 ); } p: { font-size: var(--rem);}
    3. In media query: @media (min-width: 576px) { :root{ --rem: 1.1rem; } } So you can use this technic by changing variable value only. I hope it will be useful for you.

    Have a nice coding :)

    Marked as helpful
    1
  • josephe44•170
    @josephe44Submitted over 2 years ago

    I had issues on the custom button and am yet to figure it out. Also setting the value to .toFixed(2) always return a string not a number, if you have better way, you could tell me? Also when I resolve the custom input, i would be moving the state to context, in other to manage my state properly and make my code cleaner.

    thank you, your feedback will be great

    Tip calculator app

    2
    Ali Sariyer•160
    @alisariyerPosted over 2 years ago

    Hi Josephe,

    I hope you're fine,

    You have a good work Josephe. I spent a little time for your bugs, I used your tip state callback inside handleCustomTip and used also parseFloat(({your calculation}).toFixed(2)) to fix string issue. You can always enhance your codes. So I opened a pull request on GitHub, you can observe my code changings in TipCalculForm.jsx file on your GitHub repository. If you like, you can merge. I hope these will help you.

    Have a nice coding!

    0
  • Ali Sariyer•160
    @alisariyerPosted over 2 years ago

    Hi Dominika,

    About your question, I made a pull request on GitHub for your problem about hover.

    I found a solution for your problem as removing a element, and put svg into overlay container. So not need #image positioning. I hope it will help.

    Marked as helpful
    0