I had this challenge on hold for a long time, as I couldn't get the hover effect to be centered, but I finally managed to finish it. Any tips for me to improve my project I'm happy to accept
Alimuddin Hasan
@alimuddinhasanAll comments
- @RafisEliasSubmitted over 2 years ago@alimuddinhasanPosted over 2 years ago
Good job, I like your work, the detail is beautiful. As a reminder, don't forget to remove the unnecessary console.log. I saw it in the console when I opened your site.
0 - @NATiiCODESSubmitted over 2 years ago
This is my first project with FrontEnd Mentor.
I used alot of W3school and google to figure out some of what I was missing.
I am having difficulty with the paragraph I am trying to get it like the before but I cant seem to figure it out. I am sure it is right in my face the whole time but I am drawing blank at the moment. Especially on the spacing between the description and picture.
If anyone could give me some feedback that would be greatly appreciated.
Thank you!
@alimuddinhasanPosted over 2 years agoHello there,
First of all, you need to understand how the layout works with CSS. You can use flexbox or grid for this purpose. Here are some references to it https://css-tricks.com/snippets/css/a-guide-to-flexbox/ https://css-tricks.com/snippets/css/complete-guide-grid/
As the space between the picture and product detail, you can use margin or padding. To understand them, you need to know how the HTML element works. You can learn it from any resources, but I recommend you to learn from https://www.freecodecamp.org/learn/2022/responsive-web-design/
0 - @alphardhafizSubmitted over 2 years ago
how the best practice in this case? use grid or flexbox?
@alimuddinhasanPosted over 2 years agoSince the product detail section needs the flexibility to arrange the element, I recommend you to use flexbox. You can use default flex direction for outer section and use column for product detail section.
Marked as helpful0 - @R4f0soSubmitted over 2 years ago
- Is my code too long?
- Have I wrote a code following the best practices? What can I improve?
- Is the responsiveness well made?
- In terms of skills of both CSS and HTML, what can I improve?
- To do the responsiveness I got to use the flex-wrap property in order to move my image to the top. Are any other ways to do this?
@alimuddinhasanPosted over 2 years ago- I don't think your code is too long, but I suggest ensuring your indentation is correct. It looks like a simple thing, but believe me, it helps a lot for code readability. If you use vscode, try prettier extension
- Your project structure is a bit unusual. It works but does not follow the best practice. For instance, you should put the CSS files in the style folder instead of the src
Marked as helpful0 - @PriyankaArikatla1205Submitted over 2 years ago@alimuddinhasanPosted over 2 years ago
Your card is not centered, try to use flexbox to achieve it. The explanation in this web is good for you to start https://css-tricks.com/snippets/css/a-guide-to-flexbox/
0