I'm starting to feel more comfortable working with SCSS. Even if I'm quite happy with the way my js works, it might be cleaner next time.
Ali AbuEl3iz
@ali007-depugAll comments
- @DaniilGurskiSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
- @Venktesh-KaviarasanSubmitted 11 months ago
-
Found it hard to manage the card for different screen sizes and make it responsive. Even now its not responsive.
-
Even though the card is made flex, it is not responding for lower resolution sizes.
@ali007-depugPosted 11 months agouse clamp function css tk make it responsive read articles about it
0 -
- @Bouen123Submitted 11 months ago@ali007-depugPosted 11 months ago
great .. but there is issue on mobile screen, there is a large padding on left and right, check it and fix it
0 - @nachospreaficoSubmitted 11 months ago
Hello and happy holidays to everyone!
I have made this using React and Tailwind CSS. I didn't have the figma files so everything was done eyeballing it.
I am getting better at it, but using grid layouts is something I am still struggling with.
Any feedback will be much appreciated!
Thanks in advance!
- @Ashraf-HessenSubmitted 11 months ago
- I used CSS Grid to style the layout of all content parts, is It right?
- I didn't use ARIA, is it necessary?
@ali007-depugPosted 11 months agoyes it's necessary to use ARIA , it's for accessibility
0 - @Kurkov11Submitted 11 months ago
Any feedback is welcome
@ali007-depugPosted 11 months agowell done, it's include semantics HTML like main and section, also you can use "header" for logo and desktop navBar, for accessible,test it on browser dev tool on my phone the layout is very good your code is readable but try to write some comments on css and i noticed that you are using only id , why no " class " instead .. read some article about using class and id and what is best practice
1 - @vincent453Submitted 11 months ago@ali007-depugPosted 11 months ago
well done, but try to enhance your code by writing readable comments and usr obvious naming in your classes and ids ... etc 👏👏
0 - @EmrahIsoSubmitted 11 months ago
Am I using commit too much?
@ali007-depugPosted 11 months agoi need to see your code, you are insert another github repo, the QR code
1 - @mochimoooSubmitted almost 2 years ago
Hi Frontend Mentor peers~
I am uploading this challenge knowing that I haven't complete all the requirement and I need some help.
I have trouble figuring how to make the image to show the viewing icon when the cursor hovers over it, and I don't know where to begin looking for help. I'd appreciate if you can give me some guidance, including good online resources to read, to help me understand what I need to learn.
Secondly, if you have any additional tips on how to improve my code, it's greatly appreciated. #bestpractices
Thank you!
@ali007-depugPosted almost 2 years agohello.. first: you have to put the blue image and eye-icon on one div.. second try to center the blue image.. after that.. try to center the eye-icon ... and give it the light blue color.. now you have eye-icon above the blue image.. finally.. set the "opacity" of eye-icon is 0. and on hover.. set it to one..
i hope it helps..
1 - @SvprnceSubmitted almost 2 years ago
How to Improve My Css ?
@ali007-depugPosted almost 2 years agou can improve your css by doing it alot.. just keep doing it, search for things that you don't understanding , show other people code watch video tutorial...etc Good luck
0 - @lu0teroSubmitted over 2 years ago
All feedback is welcome! Feel free to comment!
@ali007-depugPosted over 2 years agoit's great but do you feel like your image need a some border-radius?
0