All comments

• 

  ToroDev• 20

  @heitorcallipo

  Submitted over 1 year ago

  1. Trying to use more "em" and "rem", is it correct to use that way?
  2. As a simple challenge, but very good to train some CSS skills, hit me with some ideas of what to do correctly.
  3. Been struggling to know how to separate the paragraph as well as the preview one, so used <br/> tags, is it correct that way?

  

  Product Review Main Solution

  2

  20

  

  Muhammad Alkahfi Khuzaimy Abdullah• 60

  @alcoffeeocha

  Posted over 1 year ago

  CMIIW (1) Yeah, that's good for accessibility if user want to change the browser font size. But, it does not change if user zoom in or out. I think, Border/Shadow width = px // Icon size = em (When inline with text) // Margin for typography = rem (For margin between heading and paragraph) // Padding for typography = em (For different button size) // Font size = em or % (For heading font size and secondary font size) // If you are unsure, use px instead (3) Me too. I feel better to create another paragraph or heading instead of <br /> and add margin-top or margin-bottom to give it space

  Marked as helpful

  0