@Luca-SousaSubmitted 7 months ago
Sean
@agoatnamedbearAll comments
- @agoatnamedbearPosted 6 months ago
Overall you did a great job.
Things to try
- Margin between header and card sections
- I couldn't quite figure out why there's a darker section below the cards
- Maybe try the mobile first approach just to see if it works for you.
Things you did well
- Mobile version looks great
- Great use of font sizing between breakpoints (something I need to work on)
Marked as helpful0 - @agoatnamedbearSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
Figuring out how to make the images display none at specific viewports
What challenges did you encounter, and how did you overcome them?Figuring how to hide elements at different viewports. I overcame this by doing research on Google.
What specific areas of your project would you like help with?I would like to learn how to better format my HTML and CSS
@agoatnamedbearPosted 7 months agoFor whatever reason the font for the main title isn't displaying correctly on the preview and the HTML report has style tags where there are none. If someone could please tell me why this is happening that would be great.
0 - @NiloyDas07Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I used rems to make sure that the card and everything in it can be easily scaled up and down in size.
What challenges did you encounter, and how did you overcome them?It was easy.
What specific areas of your project would you like help with?Nothing particular. Any feedback is appreciated.
- @CodeClaytonSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
Foi bastante facil centralizar ambas divs com flexbox e classes css, e também gosto que estou melhorando minha visão para montar um projeto com uma preview dele.
What challenges did you encounter, and how did you overcome them?Para deixar centralizado a parte da nutrição mas no final consegui, e também eu poderia usar tags semânticas do html como section.
What specific areas of your project would you like help with?no final na parte da nutrição queria saber se havia alguma solução mais fácil.
@agoatnamedbearPosted 7 months agoOverall it looks great. The only things I can see that are a bit different from the design file are:
- A bit more padding around the prep section
- A bit too much left margin for the Instructions and Nutrition sections
- The horizontal rules aren't equally distant between elements
Other than those couple of things you are doing great. Just keep practicing and you'll get even better with time.
0 - @Dav1dGPSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I am proud of how quickly I did this project. Maybe next time I will do it with Tailwind CSS.
What challenges did you encounter, and how did you overcome them?At first a bit of a mess with the display flex, but after testing everything went as I was looking for.
What specific areas of your project would you like help with?Any suggestions are welcome.
@agoatnamedbearPosted 7 months agoThe only thing that I would suggest would be a little more margin-top on the image and a little less margin-bottom under the nav. Other than that it looks awesome.
1 - @endy-devSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
s vsdb
What challenges did you encounter, and how did you overcome them?bsdbsdb
What specific areas of your project would you like help with?bsdbsdfb
@agoatnamedbearPosted 7 months ago- Background color is not correct
- Main title is not in bold lettering
- Font color for body copy is not correct
- No border around card
- Drop shadow looks great
0 - @Noelle-Wavinya-MaingiSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I am proud of the fact that I was able to finish the challenge without facing challenges.
What challenges did you encounter, and how did you overcome them?I initially assumed that i needed to generate the QR Code.I read the readme file tobetter understand the challenge.
What specific areas of your project would you like help with?What technology stack is best when creating a QR Code generator.
@agoatnamedbearPosted 7 months agoFeedback
- Margin between image and title is a bit too much
- Good job on the flexbox implementation
- Heading size may be a bit too big, I had the same issue
- Use an h1 instead of the h2 for accessability reasons
- Use a main tag to encapsulate the container instead of a div for accessibility
Marked as helpful1
